-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the docker timeout workaround #18872
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Close/reopen to rebuild |
Some static tests are failing. |
That is the failure under main 🤔 Should I also fix it? |
Those have been fixed in main so you probably need a rebase |
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
d5a3dd2
to
08dd990
Compare
The only failures we see are those that are intermittent and we already have PR's to handle those. |
I am experiencing issues due to the suppression of the workaround (even with newer version of docker 5.0.3). |
(cherry picked from commit 3154935)
closes: #18867
Remove the workaround because of the upgrade in the docker dependencies
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.