Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the docker timeout workaround #18872

Merged
merged 2 commits into from
Oct 12, 2021

Conversation

RyanSiu1995
Copy link
Contributor

closes: #18867
Remove the workaround because of the upgrade in the docker dependencies

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 10, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@RyanSiu1995 RyanSiu1995 changed the title [WIP] Remove the docker timeout workaround Remove the docker timeout workaround Oct 10, 2021
@potiuk potiuk closed this Oct 10, 2021
@potiuk potiuk reopened this Oct 10, 2021
@potiuk
Copy link
Member

potiuk commented Oct 10, 2021

Close/reopen to rebuild

@potiuk
Copy link
Member

potiuk commented Oct 11, 2021

Some static tests are failing.

@RyanSiu1995
Copy link
Contributor Author

That is the failure under main 🤔 Should I also fix it?

@uranusjr
Copy link
Member

Those have been fixed in main so you probably need a rebase

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Oct 11, 2021
@RyanSiu1995 RyanSiu1995 force-pushed the Remove-the-docker-timeout branch from d5a3dd2 to 08dd990 Compare October 12, 2021 01:34
@potiuk
Copy link
Member

potiuk commented Oct 12, 2021

The only failures we see are those that are intermittent and we already have PR's to handle those.

@potiuk potiuk merged commit 3154935 into apache:main Oct 12, 2021
@RyanSiu1995 RyanSiu1995 deleted the Remove-the-docker-timeout branch October 12, 2021 12:25
@enima2684
Copy link
Contributor

enima2684 commented Oct 21, 2021

I am experiencing issues due to the suppression of the workaround (even with newer version of docker 5.0.3).
Tasks launched with a DockerSwarmOperator with the options enable_logging=True and tty=True hangs indefinitely.
I think we still need this workaround

@potiuk potiuk added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 22, 2022
@potiuk potiuk added this to the Airflow 2.2.4 milestone Jan 22, 2022
potiuk pushed a commit that referenced this pull request Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix DockerSwarmOperator timeout
4 participants