Decrease likelihood of memory issue in CI #18852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR attempts to decrease the likelihood of memory issues for CI for non-committers. The MSSQL and MYSQL Provider and Integration tests when run together with other tests in parallel (for MSSQL even standalone) might cause memory problems (143 or 137 exit code). This PR changes the approach slightly for low-memory conditions: 1) MSSQL - both Integration and Providers tests are skipped entirely (they will be run in High-Mem case so we will see if there are any problems anyway) 2) MySQL - both Integration and Providers tests are run separately which will lead to slightly longer test runs but likely this will save us from the occasional memory issues.
|
Except few other problems (that led to few other "flaky fix" PRs) this one worked fine on my test run in my fork: https://github.com/potiuk/airflow/actions/runs/1323849397
|
|
This one also happens intermittently - and I think it would be great to merge that one to get more stable CI runs. |
eladkal
approved these changes
Oct 12, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
potiuk
added a commit
that referenced
this pull request
Jan 22, 2022
This PR attempts to decrease the likelihood of memory issues for CI for non-committers. The MSSQL and MYSQL Provider and Integration tests when run together with other tests in parallel (for MSSQL even standalone) might cause memory problems (143 or 137 exit code). This PR changes the approach slightly for low-memory conditions: 1) MSSQL - both Integration and Providers tests are skipped entirely (they will be run in High-Mem case so we will see if there are any problems anyway) 2) MySQL - both Integration and Providers tests are run separately which will lead to slightly longer test runs but likely this will save us from the occasional memory issues. (cherry picked from commit 5d9e5f6)
potiuk
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to decrease the likelihood of memory issues for
CI for non-committers. The MSSQL and MYSQL Provider and Integration
tests when run together with other tests in parallel (for MSSQL even
standalone) might cause memory problems (143 or 137 exit code).
This PR changes the approach slightly for low-memory conditions:
MSSQL - both Integration and Providers tests are skipped
entirely (they will be run in High-Mem case so we will see if
there are any problems anyway)
MySQL - both Integration and Providers tests are run separately
which will lead to slightly longer test runs but likely this
will save us from the occasional memory issues.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.