-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated usage of init_role() from API #18820
Conversation
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
I just realised instead of |
Not sure how to request permission to add to this PR but will you please add this test to confirm that #18813 was fixed?
This test fails on main but is corrected with #18820 (this PR) |
The function has been replaced by bulk_update_roles(). This PR also slightly tweaked the ordering of operations so bulk_sync_roles() is only called when there's a need to update permissions, and added a few lines in the test to make sure role rename is performed successfully.
5668ed4
to
01ab438
Compare
Some cleanups found when investigating #18813.
init_role()
has been replaced bybulk_update_roles()
. This PR also slightly tweaked the ordering of operations sobulk_sync_roles()
is only called when there's a need to update permissions, and added a few lines in the test to make sure role rename is performed successfully.