Google provider catch invalid secret name #18790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
|
missing test |
potiuk
approved these changes
Oct 7, 2021
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
|
If you can add test fr thate @raphaelauv - that would be even better, but I am not sure it's really needed in this case. |
|
thanks for the review @potiuk , I just added the test |
potiuk
approved these changes
Oct 7, 2021
|
Static check needs fixing though (I recommend pre-commit - it's really helpful to avoid extra iterations :D ) |
uranusjr
requested changes
Oct 8, 2021
airflow/providers/google/cloud/_internal_client/secret_manager_client.py
Outdated
Show resolved
Hide resolved
airflow/providers/google/cloud/_internal_client/secret_manager_client.py
Outdated
Show resolved
Hide resolved
uranusjr
approved these changes
Oct 19, 2021
sharon2719
pushed a commit
to sharon2719/airflow
that referenced
this pull request
Oct 27, 2021
54 tasks
raphaelauv
deleted the
fix/18789_google_provider_catch_invalid_secret_name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #18789