-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow disabling the Helm hooks in the helm chart #18776
Allow disabling the Helm hooks in the helm chart #18776
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for now (until we get better way to handle upgrades
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Can you add docs about this option to docs/helm-chart? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add tests?
Sure, I'll get that done. Thanks for the review |
Added tests and documentation. Let me know if you want me to add more of those |
c5944f7
to
a25e0f3
Compare
Awesome work, congrats on your first merged pull request! |
Thanks for the contribution @Mrngilles! Congrats on your first commit 🎉 |
Cool! |
this change should have been added to 1.3.0 but is not there |
Thanks @kylegalea, I see that it isn't in there, but it should have been. Let me investigate further. |
@kylegalea, thanks for bringing this up! Sorry I accidentally messed up getting this into 1.3.0. It'll definitely make it into 1.4.0. |
apache#18776 introduced a bug where it changed the Helm Hook weight for Create User job from 2 to 1. It needs to be 2 as we want to run migrations first even before create-user-job
#18776 introduced a bug where it changed the Helm Hook weight for Create User job from 2 to 1. It needs to be 2 as we want to run migrations first even before create-user-job
apache/airflow#18776 introduced a bug where it changed the Helm Hook weight for Create User job from 2 to 1. It needs to be 2 as we want to run migrations first even before create-user-job GitOrigin-RevId: 7d97547257ae436ea35ee35cf1a598ebd080050f
apache/airflow#18776 introduced a bug where it changed the Helm Hook weight for Create User job from 2 to 1. It needs to be 2 as we want to run migrations first even before create-user-job GitOrigin-RevId: 7d97547257ae436ea35ee35cf1a598ebd080050f
apache/airflow#18776 introduced a bug where it changed the Helm Hook weight for Create User job from 2 to 1. It needs to be 2 as we want to run migrations first even before create-user-job GitOrigin-RevId: 7d97547257ae436ea35ee35cf1a598ebd080050f
apache/airflow#18776 introduced a bug where it changed the Helm Hook weight for Create User job from 2 to 1. It needs to be 2 as we want to run migrations first even before create-user-job GitOrigin-RevId: 7d97547257ae436ea35ee35cf1a598ebd080050f
apache/airflow#18776 introduced a bug where it changed the Helm Hook weight for Create User job from 2 to 1. It needs to be 2 as we want to run migrations first even before create-user-job GitOrigin-RevId: 7d97547257ae436ea35ee35cf1a598ebd080050f
apache/airflow#18776 introduced a bug where it changed the Helm Hook weight for Create User job from 2 to 1. It needs to be 2 as we want to run migrations first even before create-user-job GitOrigin-RevId: 7d97547257ae436ea35ee35cf1a598ebd080050f
apache/airflow#18776 introduced a bug where it changed the Helm Hook weight for Create User job from 2 to 1. It needs to be 2 as we want to run migrations first even before create-user-job GitOrigin-RevId: 7d97547257ae436ea35ee35cf1a598ebd080050f
apache/airflow#18776 introduced a bug where it changed the Helm Hook weight for Create User job from 2 to 1. It needs to be 2 as we want to run migrations first even before create-user-job GitOrigin-RevId: 7d97547257ae436ea35ee35cf1a598ebd080050f
apache/airflow#18776 introduced a bug where it changed the Helm Hook weight for Create User job from 2 to 1. It needs to be 2 as we want to run migrations first even before create-user-job GitOrigin-RevId: 7d97547257ae436ea35ee35cf1a598ebd080050f
Following #17447, I added a way to disable the Helm hooks so that the jobs are properly created in ArgoCD.
This does not change the default behavior of the helm chart, but makes it more flexible
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.