Move DB call out of DatabricksHook.__init__
#18339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of that using `DatabricksHook` in DAG files causes tons of issues as DB calls are made everytime files is parsed.
eladkal
approved these changes
Sep 17, 2021
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
jedcunningham
approved these changes
Sep 17, 2021
kaxil
changed the title
DatabricksHook.__init__`DatabricksHook.__init__
56 tasks
54 tasks
kaxil
added a commit
to astronomer/astronomer-providers
that referenced
this pull request
Nov 16, 2021
Since apache/airflow#18339 was merged and released in 2.0.2 of Databricks provider - https://airflow.apache.org/docs/apache-airflow-providers-databricks/stable/commits.html#id1 We don't need the old code anymore.
kaxil
added a commit
to astronomer/astronomer-providers
that referenced
this pull request
Nov 16, 2021
Since apache/airflow#18339 was merged and released in 2.0.2 of Databricks provider - https://airflow.apache.org/docs/apache-airflow-providers-databricks/stable/commits.html#id1 We don't need the old code anymore. * Fix `ExternalTaskSensorAsync` test
Merged
OlympuJupiter
added a commit
to OlympuJupiter/astronomer-providers
that referenced
this pull request
Nov 14, 2022
Since apache/airflow#18339 was merged and released in 2.0.2 of Databricks provider - https://airflow.apache.org/docs/apache-airflow-providers-databricks/stable/commits.html#id1 We don't need the old code anymore. * Fix `ExternalTaskSensorAsync` test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of that using
DatabricksHookin DAG files causes tons of issues as DB calls are made everytime files is parsed.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.