Chart: warn when webserver secret key isn't set #18306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedcunningham
requested review from
ashb,
dimberman and
kaxil
as code owners
kaxil
approved these changes
Sep 20, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
approved these changes
Sep 20, 2021
jedcunningham
force-pushed
the
chart_secret_key_warning
branch
from
d6074ae to
71edcaf
Compare
We will start warning chart admins when they deploy with the default random webserver secret key, as it can lead to unnecessary restarts of the Airflow components.
kaxil
force-pushed
the
chart_secret_key_warning
branch
from
71edcaf to
6234413
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will start warning chart admins when they deploy with the default
random webserver secret key, as it can lead to unnecessary restarts of
the Airflow components.
Message on the dashboard for Admin users:
New section in production guide:
Related: #18284, #18098