Rename FileToWasbOperator to LocalFilesystemToWasbOperator #18109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
ephraimbuddy
approved these changes
Sep 9, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
eladkal
removed
the
full tests needed
56 tasks
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Feb 3, 2022
Migrate changes for file_to_wasb.py from apache/airflow#18109 related to refactor in the microsoft-azure provider package. Needed to fix tests after upgrading google provider package to the latest version Change-Id: I20e1bb1b7d4fea9f7069839949627bf8af222b17 GitOrigin-RevId: 4c109389f8c192bfe6ff28720d2559497affd8f6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The convention of local transfers is:
LocalFilesystemTo*.Examples:
airflow/airflow/providers/google/cloud/transfers/local_to_gcs.py
Line 28 in 6acb9e1
airflow/airflow/providers/amazon/aws/transfers/local_to_s3.py
Line 24 in 6acb9e1
This PR aligns the
FileToWasbOperatorwith this convention.The
FileTo*convention is an old one that we had incontrib:airflow/airflow/contrib/operators/file_to_gcs.py
Line 31 in 6acb9e1
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.