Fix BigQuery data extraction in BigQueryToMySqlOperator #18073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
|
Can you also update tests? |
wolfier
force-pushed
the
remove-deprecated-method-for-bigquerytomysql-operator
branch
from
c1bdabf to
6e56b40
Compare
|
Good call! I have updated the test and made sure it works locally |
|
@wolfier Static checks are sad 😿 |
wolfier
force-pushed
the
remove-deprecated-method-for-bigquerytomysql-operator
branch
from
6e56b40 to
0986933
Compare
wolfier
force-pushed
the
remove-deprecated-method-for-bigquerytomysql-operator
branch
from
0986933 to
8d4f76e
Compare
|
My bad! The tests I ran skipped the flake8 test for some reason :( I made sure to run the test for the test file explicitly and it did pass 🤞 |
kaxil
approved these changes
Sep 8, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
56 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #17198
Uses the list_rows function from BigQueryHook to query data.
If there no more rows, job is finished.