Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Neo4jHook to get the query response #18007

Merged
merged 3 commits into from
Sep 7, 2021
Merged

fix Neo4jHook to get the query response #18007

merged 3 commits into from
Sep 7, 2021

Conversation

minu7
Copy link
Contributor

@minu7 minu7 commented Sep 3, 2021

It allows to get the answer of the query from the Neo4jHook.

closes: #18005
related: #18005

@boring-cyborg
Copy link

boring-cyborg bot commented Sep 3, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@uranusjr
Copy link
Member

uranusjr commented Sep 3, 2021

Could you add/modify a test (or a couple of them since there are two branches) for this change?

@mik-laj
Copy link
Member

mik-laj commented Sep 3, 2021

@minu7 I pushed ttests. Can you look at it?

mik-laj
mik-laj reviewed Sep 3, 2021
View reviewed changes
tests/providers/neo4j/operators/test_neo4j.py
def test_neo4j_operator_test(self, mock_hook):

sql = """
MATCH (tom {name: "Tom Hanks"}) RETURN tom
"""
op = Neo4jOperator(task_id='basic_neo4j', sql=sql, dag=self.dag)
op.run(start_date=DEFAULT_DATE, end_date=DEFAULT_DATE, ignore_ti_state=True)
Copy link
Member

@mik-laj mik-laj Sep 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test took an unnecessarily long time - 6 seconds. We need a full run, but running the execute method is enough. This test also lacked assertion.

@minu7
Copy link
Contributor Author

minu7 commented Sep 7, 2021

Sorry for the late reply, the tests look good, thanks 👍

@mik-laj
Copy link
Member

mik-laj commented Sep 7, 2021

@uranusjr @potiuk Can you look at it?

uranusjr
uranusjr approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit otherwise lgtm.

tests/providers/neo4j/hooks/test_neo4j.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Sep 7, 2021
@github-actions
Copy link

github-actions bot commented Sep 7, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@mik-laj mik-laj merged commit 5d2b056 into apache:main Sep 7, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 7, 2021

Awesome work, congrats on your first merged pull request!

@potiuk potiuk mentioned this pull request Sep 30, 2021
Closed
56 tasks
@potiuk potiuk mentioned this pull request Oct 30, 2021
Closed
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mik-laj mik-laj mik-laj left review comments

@potiuk potiuk potiuk left review comments

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Neo4j Hook does not return query response
4 participants
@minu7 @uranusjr @mik-laj @potiuk