Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update production-guide.rst - include datadog #17996

Merged
merged 3 commits into from
Dec 15, 2021

Conversation

andrew-nascimento
Copy link
Contributor

This is to enable exporting of logs to a datadog agent running in the same cluster.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

This is to enable exporting of logs to a datadog agent running in the same cluster.
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 2, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

docs/helm-chart/production-guide.rst Outdated Show resolved Hide resolved
docs/helm-chart/production-guide.rst Outdated Show resolved Hide resolved
docs/helm-chart/production-guide.rst Outdated Show resolved Hide resolved
docs/helm-chart/production-guide.rst Outdated Show resolved Hide resolved
@jedcunningham jedcunningham added this to the Airflow Helm Chart 1.2.0 milestone Sep 3, 2021
@potiuk potiuk added the telemetry Telemetry-related issues label Oct 26, 2021
@jedcunningham
Copy link
Member

@a-nascimento, gentle ping. I'd love to get this merged for the next helm chart release.

@mik-laj
Copy link
Member

mik-laj commented Nov 2, 2021

We should add a section about Datadog to apache-airflow docs also.
http://airflow.apache.org/docs/apache-airflow/stable/logging-monitoring/metrics.html

@andrew-nascimento
Copy link
Contributor Author

@jedcunningham - apologies here. I have shifted roles to a new organization, so I've been a bit in flux and unable to respond.

Unfortunately, I can not currently test the suggestions above. However, I will add my comments to each based on my recollection of the issues I encountered.

I hope to be back on the slack channels in a few weeks.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Dec 15, 2021
@github-actions
Copy link

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk closed this Dec 15, 2021
@potiuk potiuk reopened this Dec 15, 2021
@jedcunningham jedcunningham merged commit 2433147 into apache:main Dec 15, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 15, 2021

Awesome work, congrats on your first merged pull request!

@jedcunningham
Copy link
Member

@andrew-nascimento, congrats on your first commit 🎉

@jedcunningham jedcunningham added the type:doc-only Changelog: Doc Only label Dec 15, 2021
@andrew-nascimento
Copy link
Contributor Author

Thanks @jedcunningham

Still trying to settle in my new role. But I am back in the Slack community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart kind:documentation okay to merge It's ok to merge this PR as it does not require more tests telemetry Telemetry-related issues type:doc-only Changelog: Doc Only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants