-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AwsBaseHook make client_type
& resource_type
optional params for get_client_type
& get_resource_type
#17987
Conversation
It will be even better! if we can refactor them somehow, it seems really confusing to me to have |
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
client_type
& resource_type
optional params for get_client_type
& get_resource_type
As suggested I added deprecation for
The values should be set only from the hook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Currently user must specify
client_type
to forget_client_type
so an example usage is:emr_client = AwsBaseHook(self.aws_conn_id, client_type='emr', region_name='us-east-1').get_client_type('emr')
however we already have
client_type
as class attribute so we can simplify it to:emr_client = AwsBaseHook(self.aws_conn_id, client_type='emr', region_name='us-east-1').get_client_type()
EDIT:
Same applied for
resource_type
withget_resource_type
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.