Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AwsBaseHook make client_type & resource_type optional params for get_client_type & get_resource_type #17987

Merged
merged 5 commits into from
Sep 3, 2021

Conversation

eladkal
Copy link
Contributor

@eladkal eladkal commented Sep 2, 2021

Currently user must specify client_type to for get_client_type so an example usage is:

emr_client = AwsBaseHook(self.aws_conn_id, client_type='emr', region_name='us-east-1').get_client_type('emr')

however we already have client_type as class attribute so we can simplify it to:

emr_client = AwsBaseHook(self.aws_conn_id, client_type='emr', region_name='us-east-1').get_client_type()

EDIT:
Same applied for resource_type with get_resource_type

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@xinbinhuang
Copy link
Contributor

xinbinhuang commented Sep 3, 2021

.get_resource_type has the same problem. Would be nice to change it here as well.

It will be even better! if we can refactor them somehow, it seems really confusing to me to have client|resource_type in both the constructor and the methods. Also, the method name looks confusing to me... (well just a personal opinion)

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Sep 3, 2021
@eladkal eladkal changed the title AwsBaseHook make client_type optional in get_client_type AwsBaseHook make client_type & resource_type optional params for get_client_type & get_resource_type Sep 3, 2021
@eladkal eladkal requested a review from uranusjr September 3, 2021 11:26
@eladkal
Copy link
Contributor Author

eladkal commented Sep 3, 2021

As suggested I added deprecation for client_type/resource_type in the function.
Current implementation may leads to a very confusing cases like:

emr_client = AwsBaseHook(self.aws_conn_id, client_type='emr', region_name='us-east-1').get_client_type(client_type='dynamodb')

The values should be set only from the hook

@xinbinhuang xinbinhuang self-requested a review September 3, 2021 15:31
Copy link
Contributor

@xinbinhuang xinbinhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants