Add possibility to run DAGs from system tests and see DAGs logs #17868
Conversation
boring-cyborg
bot
added
area:providers
provider:google
|
Reopened to rebuild |
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
|
Some static checks failing |
|
@potiuk can we put this PR on hold for a while? These are not all required changes. I need to fix few more tests and only then the commit will be fully ready. |
|
Sure! Convert it to Draft :) |
|
Just did :) |
Thanks! |
|
@potiuk I've finished with all required tests |
- Change 'schedule_interval' from 'None' to '@once' - Add 'setUp' and 'tearDown' methods for logs collecting
- Change 'schedule_interval' from 'None' to '@once' - Add 'setUp' and 'tearDown' methods for logs collecting
|
@potiuk could you, please, make a final review of this PR. The checks are already finished successfully |
|
We would like to merge these changes asap |
|
Looks good. Merging. Just a small comment: the ASAP word does not work in open-source :). The ASAR ( As Soon As Ready) and WCHT (When Committers Have Time) [to review and merge among hundreds of request which can be more important] are better acronyms. |
| @pytest.mark.usefixtures("helper") | ||
| @provide_gcp_context(GCP_GCS_KEY, scopes=SCOPES) | ||
| def test_run_example_dag(self): | ||
| self.run_dag('example_sheets_gcs', GSUITE_DAG_FOLDER) | ||
|
|
||
| def tearDown(self): | ||
| super().tearDown() |
There was a problem hiding this comment.
I may be missing something here... why we need this? I believe that if a method in a class is not overridden then parent method will be used, won't it?
There was a problem hiding this comment.
It was added for explicit representation and in correspondence to other tests which have setUp\tearDown methods. Also it will help to quickly add some logic to these methods inside test.
Sorry, no pressure, it was like just info )) I didn't want to push somehow by this "asap". I meant of course if you have a time would be nice from your side to review and merge these changes ;) |
|
Hey :D. no problem. Just the dynamics of open-source is very different to commercial projects, so wanted to make sure this is well understood. The "written" communication and brevity often lacks the context, so wanted to make sure the context is brought into the picture. |
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.