Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExasolHook get_pandas_df does not return pandas dataframe but None #17850

Merged
merged 6 commits into from
Aug 28, 2021
Merged

ExasolHook get_pandas_df does not return pandas dataframe but None #17850

merged 6 commits into from
Aug 28, 2021

Conversation

Goodkat
Copy link
Contributor

@Goodkat Goodkat commented Aug 26, 2021

closes #17135
ExasolHook get_pandas_df does not return pandas dataframe but None

Related to the #17135 issue: ExasolHook get_pandas_df does not return pandas dataframe but None
@eladkal
Copy link
Contributor

eladkal commented Aug 26, 2021

Can you please add unit tests https://github.com/apache/airflow/blob/main/tests/providers/exasol/hooks/test_exasol.py ?
Probably similar idea to #17777

@eladkal eladkal changed the title Update exasol.py ExasolHook get_pandas_df does not return pandas dataframe but None Aug 26, 2021
Amended the import order to pass the Static checks
Ran isort to sort imports
@Goodkat
Copy link
Contributor Author

Goodkat commented Aug 27, 2021

I am getting the Error during Static check which refers to isort and import order (as I can see).
I have run isort to sort imports in Python files, but it is still failing on this step.
Any ideas here?

Amended code formatting for get_pandas_df function
Fixed import order
Fixed import order
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ExasolHook get_pandas_df does not return pandas dataframe but None
3 participants