Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deduplicate running jobs on BigQueryInsertJobOperator #17496

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

blcksrx
Copy link
Contributor

@blcksrx blcksrx commented Aug 8, 2021

The job.result method already invokes on the hook.insert_job method, so basically it's duplicated beside of the referenced issue.

# Start the job and wait for it to complete and get the result.
job.result()
return job

In addition, In my opinion, the insert_job method should only responsible to inserting a job not verifying the job is completed and wait for it.


related: #17493

@blcksrx blcksrx requested a review from turbaszek as a code owner August 8, 2021 21:01
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Aug 8, 2021
@github-actions
Copy link

github-actions bot commented Aug 9, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Aug 9, 2021
@kaxil
Copy link
Member

kaxil commented Aug 19, 2021

Following test is failing, can you fix it please @blcksrx

  FAILED tests/providers/google/cloud/operators/test_bigquery.py::TestBigQueryInsertJobOperator::test_execute_reattach

https://github.com/apache/airflow/pull/17496/checks?check_run_id=3275336377#step:6:7406

@blcksrx
Copy link
Contributor Author

blcksrx commented Aug 31, 2021

@kaxil Thanks for noticing, it was an stupid error on unit-test side, I fixed it but unfortunately CI failed because of some conflict in installing packages that is unrelated to this PR.

@eladkal
Copy link
Contributor

eladkal commented Sep 1, 2021

@blcksrx can you please rebase - it will probably solve the CI problems

@eladkal eladkal merged commit 9a0c10b into apache:main Sep 1, 2021
@blcksrx
Copy link
Contributor Author

blcksrx commented Sep 1, 2021

@eladkal Thanks man

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants