-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for configs, secrets, networks and replicas for DockerSwarmOperator #17474
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
We now have
Around the same proximity. They should be somewhat unified. I think |
Fixed the imports as asked :) |
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great feature addition!
Left a couple of comments - hope they're helpful.
Co-authored-by: Tzu-ping Chung <[email protected]>
Hi @akki, |
Awesome work, congrats on your first merged pull request! |
Great. Congrats @enima2684 & welcome to the committers clan! 😉 |
This PR adds the following functionality to the DockerSwarmOperator :
This features are essential in order to run the DockerSwarmOperator on a production environment with shared secrets, configs and networks.
The issue #7955 also mentions the need for this features.
P.S: this is my first contribution to Airflow. Tried to follow the contribution guidelines. Forgive any missed step and looking forward for your feedback !
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.