Fixed SlackAPIFileOperator to upload file and file content #17247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
changed the title
uranusjr
reviewed
Jul 28, 2021
uranusjr
reviewed
Jul 30, 2021
Fixed indentation. Co-authored-by: Tzu-ping Chung <[email protected]>
uranusjr
approved these changes
Jul 30, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
eladkal
reviewed
Jul 31, 2021
| if not self.api_params: | ||
| self.construct_api_call_params() | ||
| slack = SlackHook(token=self.token, slack_conn_id=self.slack_conn_id) | ||
| slack.call(self.method, data=self.api_params, files=self.file_params) |
There was a problem hiding this comment.
Why do we need to pass filename in both files & data ?
api_params has a filename key that contains self.filename
file_params has file key that contains self.filename
potiuk
approved these changes
Aug 1, 2021
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes slackApiFileOperator so that both content and file can be uploaded.
closes: #14880