Parse JSON template parameters field for MySQL operator #17080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
uranusjr
reviewed
Jul 19, 2021
oyarushe
force-pushed
the
feature/mysql-operator-parse-parameter-field-for-template-json-file
branch
from
3b6e9af to
89bd6d2
Compare
uranusjr
approved these changes
Jul 19, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
approved these changes
Jul 19, 2021
oyarushe
force-pushed
the
feature/mysql-operator-parse-parameter-field-for-template-json-file
branch
from
89bd6d2 to
e4d4be6
Compare
|
Looks like test_trino failed. |
oyarushe
force-pushed
the
feature/mysql-operator-parse-parameter-field-for-template-json-file
branch
from
e4d4be6 to
1bcfdfd
Compare
|
Closed/Reopened to rebuild |
66 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #16914, we added
.jsonto template extensions, it will be used forparametersfield which supposed to be dict or list.So it will be good to parse JSON files for parameters.
Now it fails:
After fix:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.