Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed DAG triggering with parameters #16815

Closed
wants to merge 1 commit into from
Closed

Fixed DAG triggering with parameters #16815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airflow/www/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1523,7 +1523,7 @@ def trigger(self, session=None):
if request_conf:
try:
run_conf = json.loads(request_conf)
if not isinstance(conf, dict):
if not isinstance(run_conf, dict):
flash("Invalid JSON configuration, must be a dict", "error")
return self.render_template(
'airflow/trigger.html', dag_id=dag_id, origin=origin, conf=request_conf
Expand Down
1 change: 0 additions & 1 deletion tests/www/views/test_views_trigger_dag.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ def test_trigger_dag_button(admin_client):
assert run.run_type == DagRunType.MANUAL


@pytest.mark.quarantined
uranusjr marked this conversation as resolved.
Show resolved Hide resolved
def test_trigger_dag_conf(admin_client):
test_dag_id = "example_bash_operator"
conf_dict = {'string': 'Hello, World!'}
Expand Down