Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy GitHub Packages #16776

Merged
merged 1 commit into from
Jul 4, 2021
Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jul 2, 2021

This PR removes the legacy GitHub Packages support:

  • removes checking for images in Packages/Registry
  • removes output informing about the registry
  • hard-codes registry to ghcr.io
  • Updaes documentation describing the registries

Part of #16555


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk potiuk force-pushed the remove-github-packages branch 2 times, most recently from df78ae1 to e4c9751 Compare July 2, 2021 14:12
@potiuk potiuk changed the title Switches completely to ghcr.io for development chaing Remove legacy GitHub Packages Jul 2, 2021
@potiuk potiuk requested review from eladkal, kaxil and uranusjr July 2, 2021 14:13
@potiuk potiuk marked this pull request as ready for review July 2, 2021 14:13
@potiuk potiuk requested a review from ashb as a code owner July 2, 2021 14:13
@potiuk
Copy link
Member Author

potiuk commented Jul 2, 2021

Looks like we are good to merge this one. The ghcr.io switch seems successful.

@potiuk
Copy link
Member Author

potiuk commented Jul 3, 2021

Good to go this one

This PR removes the legacy GitHub Packages support:
* removes checking for images in Packages/Registry
* removes output informing about the registry
* hard-codes registry to ghcr.io
* Updaes documentation describing the registries
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can’t say I understand some of the bash stuff but as far a I can tell this is good to merge.

@github-actions
Copy link

github-actions bot commented Jul 4, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jul 4, 2021
@potiuk potiuk merged commit b251d22 into apache:main Jul 4, 2021
@potiuk potiuk deleted the remove-github-packages branch July 4, 2021 11:44
@potiuk
Copy link
Member Author

potiuk commented Jul 4, 2021

Can’t say I understand some of the bash stuff but as far a I can tell this is good to merge.

Yeah. Once we simplify some of that I hope we can finally rewrite it in Python: #12282.

This image building and caching done efficiently for development will now be much easier. Some of the complexity I am removing now was because we used both GitHub Packages (For CI) and DockerHub (for Breeze). That was because we did not want to have additional authentication for DockerHub pushing images from CI (and we ere afraid it won't handle the per-build CI images we have). On the other hand, GitHub Packages did not have the option of "Public" images. Now with ghcr.io which was promoted to GA recently, we have both - built-in authentication using GITHUB_TOKEN and public images, so we can finally switch I think.

I will start gradually replacing parts of the bash scripts with Python soon I think (and invite others to help)

With #16780 we are switching Breeze completely to ghcr.io as well and then managing of images becomes much simpler, it did not make much sense to rewrite all the complexity in Python (even in Python it would be equally complex).

potiuk added a commit that referenced this pull request Jul 18, 2021
This PR removes the legacy GitHub Packages support:
* removes checking for images in Packages/Registry
* removes output informing about the registry
* hard-codes registry to ghcr.io
* Updaes documentation describing the registries

(cherry picked from commit b251d22)
kaxil pushed a commit that referenced this pull request Aug 17, 2021
This PR removes the legacy GitHub Packages support:
* removes checking for images in Packages/Registry
* removes output informing about the registry
* hard-codes registry to ghcr.io
* Updaes documentation describing the registries

(cherry picked from commit b251d22)
jhtimmins pushed a commit that referenced this pull request Aug 17, 2021
This PR removes the legacy GitHub Packages support:
* removes checking for images in Packages/Registry
* removes output informing about the registry
* hard-codes registry to ghcr.io
* Updaes documentation describing the registries

(cherry picked from commit b251d22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants