-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy GitHub Packages #16776
Conversation
df78ae1
to
e4c9751
Compare
Looks like we are good to merge this one. The |
Good to go this one |
This PR removes the legacy GitHub Packages support: * removes checking for images in Packages/Registry * removes output informing about the registry * hard-codes registry to ghcr.io * Updaes documentation describing the registries
e4c9751
to
c0f5f1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can’t say I understand some of the bash stuff but as far a I can tell this is good to merge.
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Yeah. Once we simplify some of that I hope we can finally rewrite it in Python: #12282. This image building and caching done efficiently for development will now be much easier. Some of the complexity I am removing now was because we used both GitHub Packages (For CI) and DockerHub (for Breeze). That was because we did not want to have additional authentication for DockerHub pushing images from CI (and we ere afraid it won't handle the per-build CI images we have). On the other hand, GitHub Packages did not have the option of "Public" images. Now with I will start gradually replacing parts of the bash scripts with Python soon I think (and invite others to help) With #16780 we are switching Breeze completely to |
This PR removes the legacy GitHub Packages support: * removes checking for images in Packages/Registry * removes output informing about the registry * hard-codes registry to ghcr.io * Updaes documentation describing the registries (cherry picked from commit b251d22)
This PR removes the legacy GitHub Packages support: * removes checking for images in Packages/Registry * removes output informing about the registry * hard-codes registry to ghcr.io * Updaes documentation describing the registries (cherry picked from commit b251d22)
This PR removes the legacy GitHub Packages support: * removes checking for images in Packages/Registry * removes output informing about the registry * hard-codes registry to ghcr.io * Updaes documentation describing the registries (cherry picked from commit b251d22)
This PR removes the legacy GitHub Packages support:
Part of #16555
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.