Don't die when masking log.exception when there is no exception
#16047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible that `exc_info` can be set, but contain no exception. We shouldn't fail in this case, even if the output doesn't make sense as shown by the test (the `NoneType: None` line is the exception being logged.)
potiuk
approved these changes
May 25, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
kaxil
approved these changes
May 25, 2021
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jun 2, 2021
…ache#16047) It is possible that `exc_info` can be set, but contain no exception. We shouldn't fail in this case, even if the output doesn't make sense as shown by the test (the `NoneType: None` line is the exception being logged.) (cherry picked from commit 2f77633)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jun 2, 2021
…ache#16047) It is possible that `exc_info` can be set, but contain no exception. We shouldn't fail in this case, even if the output doesn't make sense as shown by the test (the `NoneType: None` line is the exception being logged.) (cherry picked from commit 2f77633)
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jun 2, 2021
…ache#16047) It is possible that `exc_info` can be set, but contain no exception. We shouldn't fail in this case, even if the output doesn't make sense as shown by the test (the `NoneType: None` line is the exception being logged.) (cherry picked from commit 2f77633) (cherry picked from commit c4c2ab2)
jhtimmins
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jun 3, 2021
…ache#16047) It is possible that `exc_info` can be set, but contain no exception. We shouldn't fail in this case, even if the output doesn't make sense as shown by the test (the `NoneType: None` line is the exception being logged.) (cherry picked from commit 2f77633)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible that
exc_infocan be set, but contain no exception.We shouldn't fail in this case, even if the output doesn't make sense as
shown by the test (the
NoneType: Noneline is the exception beinglogged.)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.