Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename example bucket names to use INVALID BUCKET NAME by default #15651

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented May 4, 2021


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk potiuk requested a review from turbaszek as a code owner May 4, 2021 11:35
@boring-cyborg boring-cyborg bot added area:providers provider:Apache provider:amazon-aws AWS/Amazon - related issues provider:google Google (including GCP) related issues labels May 4, 2021
@potiuk potiuk requested review from kaxil and mik-laj May 4, 2021 11:35
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label May 4, 2021
@github-actions
Copy link

github-actions bot commented May 4, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk merged commit 0f97a39 into apache:master May 4, 2021
@potiuk potiuk deleted the replace-bucket-names-with-invalid-names branch May 4, 2021 15:32
@potiuk potiuk restored the replace-bucket-names-with-invalid-names branch April 26, 2022 20:52
@potiuk potiuk deleted the replace-bucket-names-with-invalid-names branch July 29, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:amazon-aws AWS/Amazon - related issues provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants