Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart: Add unit tests for limits and resources #15621

Merged
merged 3 commits into from
May 4, 2021

Conversation

ephraimbuddy
Copy link
Contributor

This change adds tests to validate limitrange and resourcequota templates including scheduler resources limits and requests configuration


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Apr 30, 2021
@ephraimbuddy ephraimbuddy force-pushed the test-helm-templates branch from befc7de to 5b6f1db Compare May 1, 2021 14:05
@kaxil kaxil changed the title Test helm templates Chart: Add unit tests for limits and resources May 1, 2021
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label May 1, 2021
@github-actions
Copy link

github-actions bot commented May 1, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@ephraimbuddy ephraimbuddy force-pushed the test-helm-templates branch from 5b6f1db to d56e821 Compare May 3, 2021 06:46
@ephraimbuddy ephraimbuddy force-pushed the test-helm-templates branch from d56e821 to 881e073 Compare May 3, 2021 23:07
@ephraimbuddy ephraimbuddy merged commit 1dcd3d0 into apache:master May 4, 2021
@ephraimbuddy ephraimbuddy deleted the test-helm-templates branch May 4, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants