Improve Test Coverage for Kubernetes Executor #15617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the current stats from codecov.io, the test coverage for the kubernetes_executor.py module is about 63%. This metric definitely needs to be improved upon. This PR when merge will help to improve this test coverage metric.
boring-cyborg
bot
added
the
area:Scheduler
kaxil
reviewed
Apr 30, 2021
|
@Dr-Denzy static check is failing, can you take a look plz |
The failure was coming from a black static check. I have fixed it - and the test passed on my local machine before I pushed. Hopefully, it will behave as expected in the CI build. |
kaxil
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the current stats of codecov.io assessment of the Airflow code base, the test coverage for
the kubernetes_executor.py module is about 63%. This metric definitely
needs to be improved upon.
This PR addresses the unit test coverage for the
delete_podmethod in theAirflowKubernetesSchedulerclass in the kubernetes_executor.py module. And when merged will help to improve the test coverage metric.fixes part of #15523
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.