-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SimpleHttpOperator to take auth type object #15605
Update SimpleHttpOperator to take auth type object #15605
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
This does address issue #259, although given it's age, I doubt that is relevant now, which is why I did not include it above. |
a40c27d
to
b389ac0
Compare
b389ac0
to
fa945d1
Compare
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
@fredthomsen Could you rebase please? |
fa945d1
to
d808e71
Compare
@ashb done. |
d808e71
to
ff6daf6
Compare
A `requests.auth.AuthBase` object is not passed through from the `SimpleHttpOperator` to the underlying `HttpHook`, thus if you want to use the `SimpleHttpOperator` but have a custom auth_type, you must inherit from it and override the execute method. Update the operator to take this parameter.
ff6daf6
to
f622dcb
Compare
A
requests.auth.AuthBase
object is not passed through from theSimpleHttpOperator
to the underlyingHttpHook
, thus if you want touse the
SimpleHttpOperator
but have a custom auth_type, you mustinherit from it and override the execute method. Update the operator
to take this parameter.
Seems like a small oversight that existing tests should cover.