-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIRFLOW-15: Remove gcloud #1448
Conversation
|
Test failure is due to deletion of some files, which reduces license header count. |
|
I added some license headers to make the tests pass. |
# upload from within the file context (it hasn't been | ||
# closed). | ||
tmpfile.flush() | ||
self.hook.upload(bkt, blob, tmpfile.name) | ||
except: | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the logging.error()
that is below this line (not shown in github diff) should now go inside this except statement. Otherwise it prints the error every time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. Fixing.
Please see my one comment about the error always printing. Also, I tried running this in my local env with no key in the Airflow connection (in other words, using global
But I'm not sure if this matters (or even if it's on the Airflow side), since it appears to read/write the logs to GCS just fine. One last thought -- would be great to bump this up to oauth2client 2.0 compatibility. Maybe not this PR but at some point. This is the offending line: |
I just saw your message on the Apache issue that you're already looking at compatibility issues :) Sorry for being repetitive. Need to get used to the split infrastructure... |
|
Changes Unknown when pulling 844eb2c on criccomini:remove-gcloud into * on airbnb:master*. |
@jlowin updated based on your feedback. Could I get a +1? Re: oauth compatibility, I'll bump to latest as part of https://issues.apache.org/jira/browse/AIRFLOW-16 |
Looking good to me @criccomini. Merge away. |
https://issues.apache.org/jira/browse/AIRFLOW-15