-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm RBAC Best Practices #14152
Helm RBAC Best Practices #14152
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
e894e99
to
6ed1a29
Compare
5866cdb
to
e813fb2
Compare
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
Thanks for carrying this @DerekHeldtWerle ! |
fd1292a
to
e7c5cd6
Compare
e7c5cd6
to
d857fbb
Compare
d857fbb
to
1e85ef4
Compare
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
@ashb, did you have anything else that needs to be addressed for this PR? |
1e85ef4
to
2a52a7d
Compare
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
….annotations, add items to new docs location
…, update docs with redis, jobs, and cleanup options
Co-authored-by: Ian Stanton <[email protected]>
Co-authored-by: Ian Stanton <[email protected]>
…BAC_NO_SA_KIND_NAME_TUPLES
Pushed a fix: 9ca3d21 |
9ca3d21
to
0beaee4
Compare
@kaxil beat me to it before I had seen you had pushed up your fix 😆 |
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
Thanks @DerekHeldtWerle 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR builds off of and supersedes @jaydesl's work on his PR to move forward with properly following helm's rbac best practices. This PR updates every potential pod that can be deployed to include the option to either create or use an existing service account. This is the first step towards supporting environments where users have the PodSecurityPolicy admission controller enabled without forcing such users to provide any additional permissions to the default service account in the namespace this is deployed to.
closes: #11755
related: #13643
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.