Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tableau provider separate from Salesforce Provider #14030

Merged
merged 11 commits into from
Feb 25, 2021
Merged

Add Tableau provider separate from Salesforce Provider #14030

merged 11 commits into from
Feb 25, 2021

Conversation

jyotidhiman0610
Copy link
Contributor

Closes #13614

@jyotidhiman0610 jyotidhiman0610 marked this pull request as draft February 2, 2021 13:56
@github-actions
Copy link

github-actions bot commented Feb 3, 2021

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

github-actions bot commented Feb 3, 2021

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

potiuk
potiuk approved these changes Feb 3, 2021
View reviewed changes
Copy link
Member

@potiuk potiuk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE! I will include that in the new wave of providers.! (if we make it green today that is :) )

@github-actions
Copy link

github-actions bot commented Feb 3, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Feb 3, 2021
@jyotidhiman0610
Copy link
Contributor Author

jyotidhiman0610 commented Feb 3, 2021 •
edited
Loading

Thanks @potiuk, I added one more commit for tableau provider tests and logo.

Can you please help me in testing the backward compatibility of the code?

@jyotidhiman0610 jyotidhiman0610 marked this pull request as ready for review February 3, 2021 12:35
@jyotidhiman0610 jyotidhiman0610 changed the title [WIP]: Add Tableau provider separate from Salesforce Provider Add Tableau provider separate from Salesforce Provider Feb 3, 2021
@github-actions
Copy link

github-actions bot commented Feb 3, 2021

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

github-actions bot commented Feb 9, 2021

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

github-actions bot commented Feb 9, 2021

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@kaxil
Copy link
Member

kaxil commented Feb 19, 2021

Can you rebase it on latest Master please, for some reason, tests were skipped

@jyotidhiman0610
Copy link
Contributor Author

@kaxil will do!

@github-actions
Copy link

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

@jyotidhiman0610
Copy link
Contributor Author

@kaxil , I rebased & pushed. The tests were cancelled due to Image build failure, can you please guide me a bit to achieve a green build. How do I avoid tests being skipped/cancelled?

@kaxil kaxil requested a review from potiuk February 21, 2021 00:15
@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

potiuk
potiuk approved these changes Feb 21, 2021
View reviewed changes
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@potiuk
Copy link
Member

potiuk commented Feb 21, 2021

Can you plese rebase @jyotidhiman0610 -> we had some pylint problems, but they were since solved and if you rebase to latest master, they should be solved.

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 17, 2021
@kaxil
Fix failing docs build on Master (#14465)
4f9a790 
apache/airflow#14030 caused this issue

GitOrigin-RevId: 4455f14732c207ec213703b8b8c68efeb8b6aebe
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 23, 2021
@kaxil
Fix failing docs build on Master (#14465)
42f3772 
apache/airflow#14030 caused this issue

GitOrigin-RevId: 4455f14732c207ec213703b8b8c68efeb8b6aebe
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 27, 2021
@kaxil
Fix failing docs build on Master (#14465)
77c4de5 
apache/airflow#14030 caused this issue

GitOrigin-RevId: 4455f14732c207ec213703b8b8c68efeb8b6aebe
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Mar 10, 2022
@kaxil
Fix failing docs build on Master (#14465)
fee4f5a 
apache/airflow#14030 caused this issue

GitOrigin-RevId: 4455f14732c207ec213703b8b8c68efeb8b6aebe
@eladkal eladkal mentioned this pull request May 17, 2022
Merged
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 4, 2022
@kaxil
Fix failing docs build on Master (#14465)
d81b810 
apache/airflow#14030 caused this issue

GitOrigin-RevId: 4455f14732c207ec213703b8b8c68efeb8b6aebe
potiuk pushed a commit to eladkal/airflow that referenced this pull request Jun 30, 2022
@eladkal @potiuk
Remove Tableau from Salesforce provider
e2f834d 
Tableau was split from Salesforce provider a year+ ago in apache#14030
We kept Tableau in Salesforce to preserve backward compatibility, it's time to remove the deprecated dependency.
eladkal added a commit that referenced this pull request Jul 3, 2022
@eladkal
Remove Tableau from Salesforce provider (#23747)
9c99552 
* Remove Tableau from Salesforce provider
Tableau was split from Salesforce provider a year+ ago in #14030
We kept Tableau in Salesforce to preserve backward compatibility, it's time to remove the deprecated dependency.
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 9, 2022
@kaxil
Fix failing docs build on Master (#14465)
f396d11 
apache/airflow#14030 caused this issue

GitOrigin-RevId: 4455f14732c207ec213703b8b8c68efeb8b6aebe
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Aug 27, 2022
@kaxil
Fix failing docs build on Master (#14465)
5ea92e6 
apache/airflow#14030 caused this issue

GitOrigin-RevId: 4455f14732c207ec213703b8b8c68efeb8b6aebe
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 4, 2022
@kaxil
Fix failing docs build on Master (#14465)
bd3740e 
apache/airflow#14030 caused this issue

GitOrigin-RevId: 4455f14732c207ec213703b8b8c68efeb8b6aebe
aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 7, 2022
@kaxil
Fix failing docs build on Master (#14465)
9928ce1 
apache/airflow#14030 caused this issue

GitOrigin-RevId: 4455f14732c207ec213703b8b8c68efeb8b6aebe
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Dec 7, 2022
@kaxil
Fix failing docs build on Master (#14465)
62c10f7 
apache/airflow#14030 caused this issue

GitOrigin-RevId: 4455f14732c207ec213703b8b8c68efeb8b6aebe
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jan 27, 2023
@kaxil
Fix failing docs build on Master (#14465)
060da9c 
apache/airflow#14030 caused this issue

GitOrigin-RevId: 4455f14732c207ec213703b8b8c68efeb8b6aebe
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jan 30, 2023
@eladkal
Remove Tableau from Salesforce provider (#23747)
02f6460 
* Remove Tableau from Salesforce provider
Tableau was split from Salesforce provider a year+ ago in apache/airflow#14030
We kept Tableau in Salesforce to preserve backward compatibility, it's time to remove the deprecated dependency.

GitOrigin-RevId: 9c995523f28150de3153d7cb16d605a43dbed09d
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request Sep 12, 2024
@kaxil
Fix failing docs build on Master (#14465)
5cb01f6 
apache/airflow#14030 caused this issue

GitOrigin-RevId: 4455f14732c207ec213703b8b8c68efeb8b6aebe
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this pull request Sep 12, 2024
@kaxil
Fix failing docs build on Master (#14465)
79410b9 
apache/airflow#14030 caused this issue

GitOrigin-RevId: 4455f14732c207ec213703b8b8c68efeb8b6aebe
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 17, 2024
@kaxil
Fix failing docs build on Master (#14465)
d5f1506 
apache/airflow#14030 caused this issue

GitOrigin-RevId: 4455f14732c207ec213703b8b8c68efeb8b6aebe
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 18, 2024
@eladkal
Remove Tableau from Salesforce provider (#23747)
1b19346 
* Remove Tableau from Salesforce provider
Tableau was split from Salesforce provider a year+ ago in apache/airflow#14030
We kept Tableau in Salesforce to preserve backward compatibility, it's time to remove the deprecated dependency.

GitOrigin-RevId: 9c995523f28150de3153d7cb16d605a43dbed09d
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 7, 2024
@kaxil
Fix failing docs build on Master (#14465)
b76fac2 
apache/airflow#14030 caused this issue

GitOrigin-RevId: 4455f14732c207ec213703b8b8c68efeb8b6aebe
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 7, 2024
@eladkal
Remove Tableau from Salesforce provider (#23747)
8a8a7db 
* Remove Tableau from Salesforce provider
Tableau was split from Salesforce provider a year+ ago in apache/airflow#14030
We kept Tableau in Salesforce to preserve backward compatibility, it's time to remove the deprecated dependency.

GitOrigin-RevId: 9c995523f28150de3153d7cb16d605a43dbed09d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potiuk potiuk potiuk approved these changes

@ashb ashb Awaiting requested review from ashb

@kaxil kaxil Awaiting requested review from kaxil

@mik-laj mik-laj Awaiting requested review from mik-laj

@vikramkoka vikramkoka Awaiting requested review from vikramkoka

Assignees
No one assigned
Labels
full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Separate out tableau provider from salesforce
4 participants
@jyotidhiman0610 @kaxil @potiuk @alexInhert