Unify user session lifetime configuration #11970
Conversation
github-actions
bot
added
the
full tests needed
|
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it! |
github-actions
bot
removed
the
full tests needed
michalmisiewicz
force-pushed
the
unify-user-session-lifetime-configuration
branch
from
67f55a9
to
362b45f
Compare
|
@kaxil I've rebased with master |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
@michalmisiewicz One comment left. #11970 (comment) Can you look at it, please? |
|
Hi @mik-laj , would like to have your opinion as well: if you find my comment above makes sense, let's wait for the contributor to reply; But if you find the current implementation is good enough, I'm ok to have it merged. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
michalmisiewicz
force-pushed
the
unify-user-session-lifetime-configuration
branch
from
54d6037
to
6d3c5f8
Compare
|
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it! |
github-actions
bot
added
the
full tests needed
| 'from `webserver` section. Please update your configuration.' | ||
| ) | ||
| # Stop gunicorn server https://github.com/benoitc/gunicorn/blob/20.0.4/gunicorn/arbiter.py#L526 | ||
| sys.exit(4) |
* Unify user session lifetime configuration * align with new linting rules * exit app when removed args are provided in conf * add one more test * extract stopping gunicorn to method * add docstring to stop_webserver method * use lazy formatting * exit webserver when removed options are provided * align with markdown lint * Move unify user session lifetime configuration section to master * add new line * remove quotes
* Unify user session lifetime configuration * align with new linting rules * exit app when removed args are provided in conf * add one more test * extract stopping gunicorn to method * add docstring to stop_webserver method * use lazy formatting * exit webserver when removed options are provided * align with markdown lint * Move unify user session lifetime configuration section to master * add new line * remove quotes
In current version of Airflow user session lifetime can be configured by
session_lifetime_daysandforce_log_out_after options. In practise onlysession_lifetime_dayshas impact on session lifetime, but it is limited to values in day. In this PR I have simplified user session lifetime configuration.