Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves tests that should be always executed to 'always' directory #11948

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Oct 29, 2020

Some tests (testing the structure and importability of
example) should be always run even if core part was not modified.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk potiuk requested a review from ashb October 29, 2020 17:28
@potiuk potiuk force-pushed the move-some-always-tests-to-heisentests branch from 52d7101 to cc474c8 Compare October 29, 2020 17:44
@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@potiuk potiuk force-pushed the move-some-always-tests-to-heisentests branch from cc474c8 to dc993da Compare October 29, 2020 20:36
Some tests (testing the structure and importability of
example) should be always run even if core part was not modified.

That's why we move it to "always" directory.
@potiuk potiuk force-pushed the move-some-always-tests-to-heisentests branch from dc993da to 7335d06 Compare October 29, 2020 20:59
@potiuk potiuk changed the title Moves temporarily "always" tests to heisentests Moves tests that should be always executed to 'always' directory Oct 30, 2020
@potiuk
Copy link
Member Author

potiuk commented Oct 30, 2020

Just an intermittent test failing (pr in #11963 to move it to quarantine). This one is needed to prevent structure/example dag changes that could be missed by selective checks.

@potiuk potiuk merged commit 2124453 into apache:master Oct 30, 2020
@potiuk potiuk deleted the move-some-always-tests-to-heisentests branch October 30, 2020 11:53
michalmisiewicz pushed a commit to michalmisiewicz/airflow that referenced this pull request Oct 30, 2020
…che#11948)

Some tests (testing the structure and importability of
example) should be always run even if core part was not modified.

That's why we move it to "always" directory.
szn pushed a commit to szn/airflow that referenced this pull request Nov 1, 2020
…che#11948)

Some tests (testing the structure and importability of
example) should be always run even if core part was not modified.

That's why we move it to "always" directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants