Add missing space to log message in task completion logs #11934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
approved these changes
Oct 29, 2020
|
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it! |
github-actions
bot
added
the
full tests needed
ashb
force-pushed
the
task-success-log-typo
branch
2 times, most recently
from
e112289
to
d16994f
Compare
turbaszek
reviewed
Oct 29, 2020
| @@ -1087,7 +1087,7 @@ def _run_raw_task( | |||
| self.refresh_from_db(lock_for_update=True) | |||
| self.state = State.SKIPPED | |||
| self.log.info( | |||
| 'Marking task as SKIPPED.' | |||
| 'Marking task as SKIPPED. ' | |||
| 'dag_id=%s, task_id=%s, execution_date=%s, start_date=%s, end_date=%s', | |||
There was a problem hiding this comment.
Suggested change
| 'dag_id=%s, task_id=%s, execution_date=%s, start_date=%s, end_date=%s', | |
| '(dag_id=%s, task_id=%s, execution_date=%s, start_date=%s, end_date=%s)', |
Just an idea to make it more "structured" but definitely not a blocker
turbaszek
approved these changes
Oct 29, 2020
ashb
force-pushed
the
task-success-log-typo
branch
from
d16994f
to
1ff4e75
Compare
Previously it looked like this
INFO - Marking task as SUCCESS.dag_id=scenario1_case1_1_1, ...
Now it looks like
INFO - Marking task as SUCCESS. dag_id=scenario1_case1_1_1, ...
ashb
force-pushed
the
task-success-log-typo
branch
from
1ff4e75
to
eba1dab
Compare
michalmisiewicz
pushed a commit
to michalmisiewicz/airflow
that referenced
this pull request
Oct 30, 2020
Previously it looked like this
INFO - Marking task as SUCCESS.dag_id=scenario1_case1_1_1, ...
Now it looks like
INFO - Marking task as SUCCESS. dag_id=scenario1_case1_1_1, ...
szn
pushed a commit
to szn/airflow
that referenced
this pull request
Nov 1, 2020
Previously it looked like this
INFO - Marking task as SUCCESS.dag_id=scenario1_case1_1_1, ...
Now it looks like
INFO - Marking task as SUCCESS. dag_id=scenario1_case1_1_1, ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it looked like this
Now it looks like
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.