Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Skipmixin handle empty branch properly #11120

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Make Skipmixin handle empty branch properly #11120

merged 1 commit into from
Oct 8, 2020

Conversation

yuqian90
Copy link
Contributor

Cherry picked from #10751 for v1-10-test.

This is the original commit message:

closes: #10725

  • Make sure SkipMixin.skip_all_except() handles empty branches like this properly. When "task1" is followed, "join" must not be skipped even though it is considered to be immediately downstream of "branch".
            branch  ----->  join
              \            ^
                v        /
                  task1
  • Added a test for this scenario

@yuqian90 yuqian90 mentioned this pull request Sep 24, 2020
Closed
@yuqian90 yuqian90 changed the title SkipMixin: Handle empty branches Make Skipmixin handle empty branch properly Sep 24, 2020
kaxil
kaxil approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, appreciate it @yuqian90

@kaxil kaxil added this to the Airflow 1.10.13 milestone Sep 24, 2020
@potiuk potiuk force-pushed the v1-10-test branch 2 times, most recently from bd4214b to 195f00d Compare October 3, 2020 22:42
@kaxil kaxil merged commit d355a3c into apache:v1-10-test Oct 8, 2020
kaxil pushed a commit to astronomer/airflow that referenced this pull request Oct 8, 2020
@yuqian90 @kaxil
SkipMixin: Handle empty branches (apache#11120)
64a3751 
(cherry picked from commit d355a3c)
kaxil pushed a commit that referenced this pull request Oct 11, 2020
@yuqian90 @kaxil
SkipMixin: Handle empty branches (#11120)
6974e62
RaviTezu pushed a commit to RaviTezu/airflow that referenced this pull request Oct 25, 2020
@yuqian90 @RaviTezu
SkipMixin: Handle empty branches (apache#11120)
b58aaea
kaxil pushed a commit that referenced this pull request Nov 12, 2020
@yuqian90 @kaxil
SkipMixin: Handle empty branches (#11120)
102214a
@potiuk potiuk added the type:bug-fix Changelog: Bug Fixes label Nov 14, 2020
potiuk pushed a commit that referenced this pull request Nov 16, 2020
@yuqian90 @potiuk
SkipMixin: Handle empty branches (#11120)
04807f2
kaxil pushed a commit that referenced this pull request Nov 18, 2020
@yuqian90 @kaxil
SkipMixin: Handle empty branches (#11120)
8d9217f
kaxil pushed a commit to astronomer/airflow that referenced this pull request Nov 27, 2020
@yuqian90 @kaxil
SkipMixin: Handle empty branches (apache#11120)
13f56b3 
(cherry picked from commit d355a3c)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
@yuqian90
SkipMixin: Handle empty branches (apache#11120)
3ab951b
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Merged
@yuqian90 yuqian90 deleted the v1-10-test_with_10751 branch May 29, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaxil kaxil kaxil approved these changes

Assignees
No one assigned
Labels
type:bug-fix Changelog: Bug Fixes
Projects
None yet
Milestone
Airflow 1.10.13
Development

Successfully merging this pull request may close these issues.
3 participants
@yuqian90 @kaxil @potiuk