-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fernetenabled rule and unittest #11116
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbaszek
added
the
area:upgrade
Facilitating migration to a newer version of Airflow
label
Sep 24, 2020
turbaszek
reviewed
Sep 24, 2020
turbaszek
reviewed
Sep 24, 2020
turbaszek
reviewed
Sep 24, 2020
turbaszek
reviewed
Sep 24, 2020
turbaszek
reviewed
Sep 24, 2020
turbaszek
reviewed
Sep 24, 2020
Comment on lines
27
to
30
description = ( | ||
"The fernet mechanism is enabled by default " | ||
+ "to increase the security of the default installation." | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
description = ( | |
"The fernet mechanism is enabled by default " | |
+ "to increase the security of the default installation." | |
) | |
description = "The fernet mechanism is enabled by default " \ | |
"to increase the security of the default installation." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Black did this 😅
Blackened the files, hope the strings are cleaner now |
turbaszek
approved these changes
Sep 27, 2020
turbaszek
pushed a commit
to PolideaInternal/airflow
that referenced
this pull request
Oct 21, 2020
turbaszek
pushed a commit
to PolideaInternal/airflow
that referenced
this pull request
Oct 23, 2020
(cherry picked from commit 815bc29)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
(cherry picked from commit 815bc29)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds FernetEnabled rule to
upgrade/rules
as per:https://github.com/apache/airflow/blob/master/UPDATING.md#fernet-is-enabled-by-default
Closes: #11048
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.