No option to set blocksize when retrieving a file in ftphook

[yfyg]

Apache Airflow version

2.0.0

What happened

using ftphook, im trying to download a file in chunks but the deafult blocksize is 8192 and cannot be changed.
retrieve_file code is calling conn.retrbinary(f'RETR {remote_file_name}', callback) but no blocksize is passed while this function is declared:
def retrbinary(self, cmd, callback, blocksize=8192, rest=None):

What you think should happen instead

allow passing a blocksize

How to reproduce

No response

Operating System

gcp

Versions of Apache Airflow Providers

No response

Deployment

Docker-Compose

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[boring-cyborg]

Thanks for opening your first issue here! Be sure to follow the issue template!

[josh-fell]

@yfyg It seems like you know what the feature implementation should be and can easily test it too. Do you want to submit a PR for this? Airflow has over 2K contributors and we love when new people come onboard!

[kevgeo]

Hi @yfyg, are you working on this issue? If not, @eladkal, @josh-fell, I would love to take up this issue.

[potiuk]

Feel free

[yfyg]

Hi Sorry, did not have the time to handle it yet. If someone wants to pick it up, feel free. If not I will probably be able to check it in the next 2 weeks. Thanks Yifat

…

On Tue, May 31, 2022, 19:50 Jarek Potiuk ***@***.***> wrote: Feel free — Reply to this email directly, view it on GitHub <#23935 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKTXLB7L7ILDW7UOC2HOJLVMY7NXANCNFSM5XA7PWRQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>