Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing upper bound for markupsafe #19761

Closed
2 tasks done
tsingh2k15 opened this issue Nov 23, 2021 · 1 comment · Fixed by #19953 or #20113
Closed
2 tasks done

removing upper bound for markupsafe #19761

tsingh2k15 opened this issue Nov 23, 2021 · 1 comment · Fixed by #19953 or #20113
Assignees
@tsingh2k15
Labels
area:dependencies Issues related to dependencies problems good first issue kind:task A task that needs to be completed as part of a larger issue

Comments

@tsingh2k15
Copy link
Contributor

tsingh2k15 commented Nov 23, 2021 •
edited
Loading

Description

Per discussion and guidance from #19753, opening this issue and PR #19760 for review. Based on if all the tests pass, this could be reviewed further.

Use case/motivation

Currently Jinja2 upper bound is jinja2>=2.10.1,<4 at https://github.com/apache/airflow/blob/main/setup.cfg#L121 as part of #16595

Jinja2 seems to require MarkupSafe>=2.0 at https://github.com/pallets/jinja/blob/main/setup.py#L6 as part of pallets/jinja@e2f673e

Based on this, is it feasible to consider updating upper bound in airflow for markupsafe>=1.1.1, <2.0 to allow 2.0 at https://github.com/apache/airflow/blob/main/setup.cfg#L126 ?

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@tsingh2k15 tsingh2k15 added the kind:feature Feature Requests label Nov 23, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 23, 2021

Thanks for opening your first issue here! Be sure to follow the issue template!

@tsingh2k15 tsingh2k15 mentioned this issue Nov 23, 2021
Closed
@eladkal eladkal added area:dependencies Issues related to dependencies problems good first issue kind:task A task that needs to be completed as part of a larger issue and removed kind:feature Feature Requests labels Nov 29, 2021
This was referenced Nov 29, 2021
Closed
Merged
tsingh2k15 added a commit to tsingh2k15/airflow that referenced this issue Dec 7, 2021
@tsingh2k15
Lift off upper bound for MarkupSafe
13b0af1 
Per discussion and guidance from apache#19753, opening this PR for review. Based on if all the tests pass, this could be reviewed further. Resolves apache#19761.
@tsingh2k15 tsingh2k15 mentioned this issue Dec 7, 2021
Merged
potiuk pushed a commit that referenced this issue Dec 8, 2021
@tsingh2k15
Lift off upper bound for MarkupSafe (#20113)
bcacc51 
Per discussion and guidance from #19753, opening this PR for review. Based on if all the tests pass, this could be reviewed further. Resolves #19761.
jedcunningham pushed a commit that referenced this issue Dec 8, 2021
@tsingh2k15 @jedcunningham
Lift off upper bound for MarkupSafe (#20113)
2ddb431 
Per discussion and guidance from #19753, opening this PR for review. Based on if all the tests pass, this could be reviewed further. Resolves #19761.

(cherry picked from commit bcacc51)
@jedcunningham jedcunningham mentioned this issue Dec 10, 2021
Closed
38 tasks
potiuk pushed a commit that referenced this issue Jan 22, 2022
@tsingh2k15 @potiuk
Lift off upper bound for MarkupSafe (#20113)
7bf0031 
Per discussion and guidance from #19753, opening this PR for review. Based on if all the tests pass, this could be reviewed further. Resolves #19761.

(cherry picked from commit bcacc51)
jedcunningham pushed a commit that referenced this issue Jan 27, 2022
@tsingh2k15 @jedcunningham
Lift off upper bound for MarkupSafe (#20113)
7250d89 
Per discussion and guidance from #19753, opening this PR for review. Based on if all the tests pass, this could be reviewed further. Resolves #19761.

(cherry picked from commit bcacc51)
@jedcunningham jedcunningham mentioned this issue Feb 18, 2022
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsingh2k15 tsingh2k15

Labels
area:dependencies Issues related to dependencies problems good first issue kind:task A task that needs to be completed as part of a larger issue
Projects
None yet
Milestone
No milestone
2 participants
@tsingh2k15 @eladkal