Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: check_migrations more verbose documentation #15650

Closed
andormarkus opened this issue May 4, 2021 · 1 comment · Fixed by #15662
Closed

Docs: check_migrations more verbose documentation #15650

andormarkus opened this issue May 4, 2021 · 1 comment · Fixed by #15662
Assignees
@kaxil
Labels
area:helm-chart Airflow Helm Chart kind:feature Feature Requests

Comments

@andormarkus
Copy link
Contributor

Description
The documentation and the error message of the check-migrations / def check_migrations could be more verbose. This check can fail if the underlying database was never initialised.

Use case / motivation

We are deploying our airflow helm chart with terraform helm provider. This provider has a bug with helm hook. If airflow would give us a bit more verbose error message why could the check-migrations fail, we would find the underlying error/bug much sooner.

Are you willing to submit a PR?
Yes
@andormarkus andormarkus added the kind:feature Feature Requests label May 4, 2021
@andormarkus andormarkus mentioned this issue May 4, 2021
Closed
@vikramkoka vikramkoka added the area:helm-chart Airflow Helm Chart label May 4, 2021
@vikramkoka
Copy link
Contributor

@kaxil Just tagging you since you have been working on the Airflow helm chart

kaxil added a commit to astronomer/airflow that referenced this issue May 5, 2021
@kaxil
More verbose logs when running airflow check_migrations
240b220 
Currently it just shows "TimeoutError: There are still unapplied migrations after 60 seconds. " which is not that helpful.

This commit adds more info to show the difference in migrations in DB and source code running `check_migrations`:

Now:

```
TimeoutError: There are still unapplied migrations after 60 seconds. Migration Head(s) in DB: {'e165e7455d70'} | Migration Head(s) in Source Code: {'a13f7613ad25'}
```

closes apache#15650
@kaxil kaxil mentioned this issue May 5, 2021
Merged
@kaxil kaxil self-assigned this May 5, 2021
potiuk pushed a commit that referenced this issue May 5, 2021
@kaxil
More verbose logs when running airflow check_migrations (#15662)
86ad628 
Currently it just shows "TimeoutError: There are still unapplied migrations after 60 seconds. " which is not that helpful.

This commit adds more info to show the difference in migrations in DB and source code running `check_migrations`:

Now:

```
TimeoutError: There are still unapplied migrations after 60 seconds. Migration Head(s) in DB: {'e165e7455d70'} | Migration Head(s) in Source Code: {'a13f7613ad25'}
```

closes #15650
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Sep 17, 2021
@kaxil
More verbose logs when running airflow check_migrations (#15662)
61b01db 
Currently it just shows "TimeoutError: There are still unapplied migrations after 60 seconds. " which is not that helpful.

This commit adds more info to show the difference in migrations in DB and source code running `check_migrations`:

Now:

```
TimeoutError: There are still unapplied migrations after 60 seconds. Migration Head(s) in DB: {'e165e7455d70'} | Migration Head(s) in Source Code: {'a13f7613ad25'}
```

closes apache/airflow#15650

GitOrigin-RevId: 86ad628158eb728e56c817eea2bea4ddcaa571c2
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Sep 23, 2021
@kaxil
More verbose logs when running airflow check_migrations (#15662)
77bbccb 
Currently it just shows "TimeoutError: There are still unapplied migrations after 60 seconds. " which is not that helpful.

This commit adds more info to show the difference in migrations in DB and source code running `check_migrations`:

Now:

```
TimeoutError: There are still unapplied migrations after 60 seconds. Migration Head(s) in DB: {'e165e7455d70'} | Migration Head(s) in Source Code: {'a13f7613ad25'}
```

closes apache/airflow#15650

GitOrigin-RevId: 86ad628158eb728e56c817eea2bea4ddcaa571c2
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Nov 27, 2021
@kaxil
More verbose logs when running airflow check_migrations (#15662)
fd14401 
Currently it just shows "TimeoutError: There are still unapplied migrations after 60 seconds. " which is not that helpful.

This commit adds more info to show the difference in migrations in DB and source code running `check_migrations`:

Now:

```
TimeoutError: There are still unapplied migrations after 60 seconds. Migration Head(s) in DB: {'e165e7455d70'} | Migration Head(s) in Source Code: {'a13f7613ad25'}
```

closes apache/airflow#15650

GitOrigin-RevId: 86ad628158eb728e56c817eea2bea4ddcaa571c2
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Mar 10, 2022
@kaxil
More verbose logs when running airflow check_migrations (#15662)
7d88ba0 
Currently it just shows "TimeoutError: There are still unapplied migrations after 60 seconds. " which is not that helpful.

This commit adds more info to show the difference in migrations in DB and source code running `check_migrations`:

Now:

```
TimeoutError: There are still unapplied migrations after 60 seconds. Migration Head(s) in DB: {'e165e7455d70'} | Migration Head(s) in Source Code: {'a13f7613ad25'}
```

closes apache/airflow#15650

GitOrigin-RevId: 86ad628158eb728e56c817eea2bea4ddcaa571c2
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jun 4, 2022
@kaxil
More verbose logs when running airflow check_migrations (#15662)
103bd0b 
Currently it just shows "TimeoutError: There are still unapplied migrations after 60 seconds. " which is not that helpful.

This commit adds more info to show the difference in migrations in DB and source code running `check_migrations`:

Now:

```
TimeoutError: There are still unapplied migrations after 60 seconds. Migration Head(s) in DB: {'e165e7455d70'} | Migration Head(s) in Source Code: {'a13f7613ad25'}
```

closes apache/airflow#15650

GitOrigin-RevId: 86ad628158eb728e56c817eea2bea4ddcaa571c2
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jul 9, 2022
@kaxil
More verbose logs when running airflow check_migrations (#15662)
c0a4645 
Currently it just shows "TimeoutError: There are still unapplied migrations after 60 seconds. " which is not that helpful.

This commit adds more info to show the difference in migrations in DB and source code running `check_migrations`:

Now:

```
TimeoutError: There are still unapplied migrations after 60 seconds. Migration Head(s) in DB: {'e165e7455d70'} | Migration Head(s) in Source Code: {'a13f7613ad25'}
```

closes apache/airflow#15650

GitOrigin-RevId: 86ad628158eb728e56c817eea2bea4ddcaa571c2
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Aug 27, 2022
@kaxil
More verbose logs when running airflow check_migrations (#15662)
0b55c58 
Currently it just shows "TimeoutError: There are still unapplied migrations after 60 seconds. " which is not that helpful.

This commit adds more info to show the difference in migrations in DB and source code running `check_migrations`:

Now:

```
TimeoutError: There are still unapplied migrations after 60 seconds. Migration Head(s) in DB: {'e165e7455d70'} | Migration Head(s) in Source Code: {'a13f7613ad25'}
```

closes apache/airflow#15650

GitOrigin-RevId: 86ad628158eb728e56c817eea2bea4ddcaa571c2
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Oct 4, 2022
@kaxil
More verbose logs when running airflow check_migrations (#15662)
8be7e31 
Currently it just shows "TimeoutError: There are still unapplied migrations after 60 seconds. " which is not that helpful.

This commit adds more info to show the difference in migrations in DB and source code running `check_migrations`:

Now:

```
TimeoutError: There are still unapplied migrations after 60 seconds. Migration Head(s) in DB: {'e165e7455d70'} | Migration Head(s) in Source Code: {'a13f7613ad25'}
```

closes apache/airflow#15650

GitOrigin-RevId: 86ad628158eb728e56c817eea2bea4ddcaa571c2
aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Oct 7, 2022
@kaxil
More verbose logs when running airflow check_migrations (#15662)
40d6c57 
Currently it just shows "TimeoutError: There are still unapplied migrations after 60 seconds. " which is not that helpful.

This commit adds more info to show the difference in migrations in DB and source code running `check_migrations`:

Now:

```
TimeoutError: There are still unapplied migrations after 60 seconds. Migration Head(s) in DB: {'e165e7455d70'} | Migration Head(s) in Source Code: {'a13f7613ad25'}
```

closes apache/airflow#15650

GitOrigin-RevId: 86ad628158eb728e56c817eea2bea4ddcaa571c2
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Dec 7, 2022
@kaxil
More verbose logs when running airflow check_migrations (#15662)
e6da59e 
Currently it just shows "TimeoutError: There are still unapplied migrations after 60 seconds. " which is not that helpful.

This commit adds more info to show the difference in migrations in DB and source code running `check_migrations`:

Now:

```
TimeoutError: There are still unapplied migrations after 60 seconds. Migration Head(s) in DB: {'e165e7455d70'} | Migration Head(s) in Source Code: {'a13f7613ad25'}
```

closes apache/airflow#15650

GitOrigin-RevId: 86ad628158eb728e56c817eea2bea4ddcaa571c2
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jan 27, 2023
@kaxil
More verbose logs when running airflow check_migrations (#15662)
86e5d75 
Currently it just shows "TimeoutError: There are still unapplied migrations after 60 seconds. " which is not that helpful.

This commit adds more info to show the difference in migrations in DB and source code running `check_migrations`:

Now:

```
TimeoutError: There are still unapplied migrations after 60 seconds. Migration Head(s) in DB: {'e165e7455d70'} | Migration Head(s) in Source Code: {'a13f7613ad25'}
```

closes apache/airflow#15650

GitOrigin-RevId: 86ad628158eb728e56c817eea2bea4ddcaa571c2
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this issue Sep 12, 2024
@kaxil
More verbose logs when running airflow check_migrations (#15662)
0caa06a 
Currently it just shows "TimeoutError: There are still unapplied migrations after 60 seconds. " which is not that helpful.

This commit adds more info to show the difference in migrations in DB and source code running `check_migrations`:

Now:

```
TimeoutError: There are still unapplied migrations after 60 seconds. Migration Head(s) in DB: {'e165e7455d70'} | Migration Head(s) in Source Code: {'a13f7613ad25'}
```

closes apache/airflow#15650

GitOrigin-RevId: 86ad628158eb728e56c817eea2bea4ddcaa571c2
kosteev pushed a commit to kosteev/composer-airflow-test-copybara that referenced this issue Sep 13, 2024
@kaxil
More verbose logs when running airflow check_migrations (#15662)
5238b06 
Currently it just shows "TimeoutError: There are still unapplied migrations after 60 seconds. " which is not that helpful.

This commit adds more info to show the difference in migrations in DB and source code running `check_migrations`:

Now:

```
TimeoutError: There are still unapplied migrations after 60 seconds. Migration Head(s) in DB: {'e165e7455d70'} | Migration Head(s) in Source Code: {'a13f7613ad25'}
```

closes apache/airflow#15650

GitOrigin-RevId: 86ad628158eb728e56c817eea2bea4ddcaa571c2
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Sep 17, 2024
@kaxil
More verbose logs when running airflow check_migrations (#15662)
0ebd5d7 
Currently it just shows "TimeoutError: There are still unapplied migrations after 60 seconds. " which is not that helpful.

This commit adds more info to show the difference in migrations in DB and source code running `check_migrations`:

Now:

```
TimeoutError: There are still unapplied migrations after 60 seconds. Migration Head(s) in DB: {'e165e7455d70'} | Migration Head(s) in Source Code: {'a13f7613ad25'}
```

closes apache/airflow#15650

GitOrigin-RevId: 86ad628158eb728e56c817eea2bea4ddcaa571c2
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Nov 7, 2024
@kaxil
More verbose logs when running airflow check_migrations (#15662)
c18d445 
Currently it just shows "TimeoutError: There are still unapplied migrations after 60 seconds. " which is not that helpful.

This commit adds more info to show the difference in migrations in DB and source code running `check_migrations`:

Now:

```
TimeoutError: There are still unapplied migrations after 60 seconds. Migration Head(s) in DB: {'e165e7455d70'} | Migration Head(s) in Source Code: {'a13f7613ad25'}
```

closes apache/airflow#15650

GitOrigin-RevId: 86ad628158eb728e56c817eea2bea4ddcaa571c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaxil kaxil

Labels
area:helm-chart Airflow Helm Chart kind:feature Feature Requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

More verbose logs when running airflow check_migrations astronomer/airflow
3 participants
@kaxil @vikramkoka @andormarkus