Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart/templates/secrets/metadata-connection-secret.yaml postgres hardcode? #15558

Closed
jiamo opened this issue Apr 28, 2021 · 1 comment · Fixed by #15616
Closed

chart/templates/secrets/metadata-connection-secret.yaml postgres hardcode? #15558

jiamo opened this issue Apr 28, 2021 · 1 comment · Fixed by #15616
Assignees
Labels
area:helm-chart Airflow Helm Chart kind:feature Feature Requests

Comments

@jiamo
Copy link

jiamo commented Apr 28, 2021

Can't deploy airflow chart with mysql backend?

I find chart/templates/secrets/metadata-connection-secret.yaml postgres with such code

data:
     connection: {{ (printf "postgresql://%s:%s@%s:%s/%s?sslmode=%s" .Values.data.metadataConnection.user .Values.data.metadataConnection.pass $host $port $database .Values.data.metadataConnection.sslmode) | b64enc | quote }}

while chart/Values.yaml

data:
  # If secret names are provided, use those secrets
  metadataSecretName: ~
  resultBackendSecretName: ~
  brokerUrlSecretName: ~

  # Otherwise pass connection values in
  metadataConnection:
    user: ~
    pass: ~

Here we can't specify mysql or postgresql if we don't specify metadataSecretName.

@jiamo jiamo added the kind:bug This is a clearly a bug label Apr 28, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 28, 2021

Thanks for opening your first issue here! Be sure to follow the issue template!

@mik-laj mik-laj added kind:feature Feature Requests and removed kind:bug This is a clearly a bug labels Apr 28, 2021
@jedcunningham jedcunningham self-assigned this Apr 30, 2021
@jedcunningham jedcunningham added the area:helm-chart Airflow Helm Chart label Apr 30, 2021
kaxil pushed a commit that referenced this issue Apr 30, 2021
While we generally suggest using Postgres, we should support using a
non-chart-provisioned mysql database as well.

closes: #15558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart kind:feature Feature Requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants