Migrate Microsoft example DAGs to new design #22452 - winrm (#24140)

* Migrate Microsoft example DAGs to new design #22452 - winrm * Fix static checks
apache · Jun 3, 2022 · fcf47e1 · fcf47e1
1 parent 6e83885
commit fcf47e1
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 21 deletions.
diff --git a/airflow/providers/microsoft/winrm/example_dags/__init__.py b/airflow/providers/microsoft/winrm/example_dags/__init__.py
diff --git a/docs/apache-airflow-providers-microsoft-winrm/index.rst b/docs/apache-airflow-providers-microsoft-winrm/index.rst
@@ -38,7 +38,7 @@ Content
     :maxdepth: 1
     :caption: Resources
 
-    Example DAGs <https://github.com/apache/airflow/tree/main/airflow/providers/microsoft/winrm/example_dags>
+    Example DAGs <https://github.com/apache/airflow/tree/main/tests/system/providers/microsoft/winrm>
     PyPI Repository <https://pypi.org/project/apache-airflow-providers-microsoft-winrm/>
     Installing from sources <installing-providers-from-sources>
 

diff --git a/docs/apache-airflow-providers-microsoft-winrm/operators.rst b/docs/apache-airflow-providers-microsoft-winrm/operators.rst
@@ -22,15 +22,15 @@ use the WinRMOperator to execute commands on a given remote host using the winrm
 
 create a hook
 
-.. exampleinclude:: /../../airflow/providers/microsoft/winrm/example_dags/example_winrm.py
+.. exampleinclude:: /../../tests/system/providers/microsoft/winrm/example_winrm.py
     :language: python
     :dedent: 4
     :start-after: [START create_hook]
     :end-before: [END create_hook]
 
 Run the operator, pass the hook, and pass a command to do something
 
-.. exampleinclude:: /../../airflow/providers/microsoft/winrm/example_dags/example_winrm.py
+.. exampleinclude:: /../../tests/system/providers/microsoft/winrm/example_winrm.py
     :language: python
     :dedent: 4
     :start-after: [START run_operator]

diff --git a/...osoft/winrm/example_dags/example_winrm.py → ...roviders/microsoft/winrm/example_winrm.py b/...osoft/winrm/example_dags/example_winrm.py → ...roviders/microsoft/winrm/example_winrm.py
@@ -26,6 +26,7 @@
 """
 This is an example dag for using the WinRMOperator.
 """
+import os
 from datetime import datetime, timedelta
 
 from airflow import DAG
@@ -34,11 +35,15 @@
     from airflow.operators.empty import EmptyOperator
 except ModuleNotFoundError:
     from airflow.operators.dummy import DummyOperator as EmptyOperator  # type: ignore
+
 from airflow.providers.microsoft.winrm.hooks.winrm import WinRMHook
 from airflow.providers.microsoft.winrm.operators.winrm import WinRMOperator
 
+ENV_ID = os.environ.get("SYSTEM_TESTS_ENV_ID")
+DAG_ID = "POC_winrm_parallel"
+
 with DAG(
-    dag_id='POC_winrm_parallel',
+    dag_id=DAG_ID,
     schedule_interval='0 0 * * *',
     start_date=datetime(2021, 1, 1),
     dagrun_timeout=timedelta(minutes=60),
@@ -61,3 +66,14 @@
     # [END run_operator]
 
     [t1, t2, t3] >> run_this_last
+
+    from tests.system.utils.watcher import watcher
+
+    # This test needs watcher in order to properly mark success/failure
+    # when "tearDown" task with trigger rule is part of the DAG
+    list(dag.tasks) >> watcher()
+
+from tests.system.utils import get_test_run  # noqa: E402
+
+# Needed to run the example DAG with pytest (see: tests/system/README.md#run_via_pytest)
+test_run = get_test_run(dag)