Skip to content

Commit

Permalink
Fix suffix for pre-release cross-dependent packages
Browse files Browse the repository at this point in the history
We used .* as suffix for dependent pre-release packages but it
turned out to be misunderstanding of the dependencies and PEP440.

According to PEP440 the dev/a/b/c(rc) versions are strictly ordered
and ">=X.Y.Z.dev0" is equivalent of "depends on any pre-release
package of X.Y.Z and all packages that follow".

Result of discusion in python-poetry/poetry#7047
  • Loading branch information
potiuk committed Nov 17, 2022
1 parent 973406b commit eb7a54d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dev/provider_packages/prepare_provider_packages.py
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ def apply_version_suffix(install_clause: str) -> str:
# including all development releases. When you specify dependency as >= X.Y.Z, and you
# have packages X.Y.Zdev0 or X.Y.Zrc1 in a local file, such package is not considered
# as fulfilling the requirement even if `--pre` switch is used.
return install_clause + ".*"
return install_clause + ".dev0"
return install_clause

install_requires = [
Expand Down

0 comments on commit eb7a54d

Please sign in to comment.