Skip to content

Commit

Permalink
Add missing default for version suffix (#35842)
Browse files Browse the repository at this point in the history
The missing default was causing the suffix to be None when not
specified and crashing package building.
  • Loading branch information
potiuk authored and ephraimbuddy committed Nov 26, 2023
1 parent 4fd6166 commit db69770
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 3 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -830,6 +830,10 @@ jobs:
if: needs.build-info.outputs.affected-providers-list-as-string != ''
env:
SKIP_CONSTRAINTS: "${{ needs.build-info.outputs.upgrade-to-newer-dependencies }}"
- name: "Prepare airflow package: wheel without suffix and skipping the tag check"
run: >
breeze release-management prepare-provider-packages --skip-tag-check
--package-format wheel ${{ needs.build-info.outputs.affected-providers-list-as-string }}
provider-airflow-compatibility-check:
timeout-minutes: 80
Expand Down
1 change: 1 addition & 0 deletions dev/breeze/src/airflow_breeze/utils/common_options.py
Original file line number Diff line number Diff line change
Expand Up @@ -414,6 +414,7 @@ def _set_default_from_parent(ctx: click.core.Context, option: click.core.Option,
"--version-suffix-for-pypi",
help="Version suffix used for PyPI packages (alpha, beta, rc1, etc.).",
envvar="VERSION_SUFFIX_FOR_PYPI",
default="",
)
option_version_suffix_for_pypi_ci = click.option(
"--version-suffix-for-pypi",
Expand Down
2 changes: 1 addition & 1 deletion images/breeze/output_prod-image_build.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
5ae644dee2b69e91dbcd593cdeebd3e7
efdd516ea49fd7f8f9c770fa466d879b
Original file line number Diff line number Diff line change
@@ -1 +1 @@
91b0782d87b4e0ed7ce6e8cb231adafd
5077bcfc4272c969f8b80ea4438a438a
Original file line number Diff line number Diff line change
@@ -1 +1 @@
2bb361f519c8165e884439722e76e945
1b7d25cb5f379cee89c5345c60be1992

0 comments on commit db69770

Please sign in to comment.