Skip to content

Commit

Permalink
Chart: Change default executor to CeleryExecutor (#15603)
Browse files Browse the repository at this point in the history
``CeleryExecutor`` is currently the most stable of all, so it should be the default when using the Helm Chart.
  • Loading branch information
kaxil authored Apr 30, 2021
1 parent 7f6ddda commit c7cd437
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
10 changes: 9 additions & 1 deletion chart/tests/test_basic_helm_chart.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

from tests.helm_template_generator import render_chart

OBJECT_COUNT_IN_BASIC_DEPLOYMENT = 22
OBJECT_COUNT_IN_BASIC_DEPLOYMENT = 30


class TestBaseChartTest(unittest.TestCase):
Expand Down Expand Up @@ -55,13 +55,21 @@ def test_basic_deployments(self):
('RoleBinding', 'TEST-BASIC-pod-log-reader-rolebinding'),
('Service', 'TEST-BASIC-postgresql-headless'),
('Service', 'TEST-BASIC-postgresql'),
('Service', 'TEST-BASIC-flower'),
('Service', 'TEST-BASIC-redis'),
('Service', 'TEST-BASIC-statsd'),
('Service', 'TEST-BASIC-webserver'),
('Service', 'TEST-BASIC-worker'),
('Deployment', 'TEST-BASIC-flower'),
('Deployment', 'TEST-BASIC-scheduler'),
('Deployment', 'TEST-BASIC-statsd'),
('Deployment', 'TEST-BASIC-webserver'),
('StatefulSet', 'TEST-BASIC-postgresql'),
('StatefulSet', 'TEST-BASIC-redis'),
('StatefulSet', 'TEST-BASIC-worker'),
('Secret', 'TEST-BASIC-fernet-key'),
('Secret', 'TEST-BASIC-redis-password'),
('Secret', 'TEST-BASIC-broker-url'),
('Job', 'TEST-BASIC-create-user'),
('Job', 'TEST-BASIC-run-airflow-migrations'),
]
Expand Down
2 changes: 1 addition & 1 deletion chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ rbacEnabled: true

# Airflow executor
# Options: LocalExecutor, CeleryExecutor, KubernetesExecutor, CeleryKubernetesExecutor
executor: "KubernetesExecutor"
executor: "CeleryExecutor"

# If this is true and using LocalExecutor/KubernetesExecutor/CeleryKubernetesExecutor, the scheduler's
# service account will have access to communicate with the api-server and launch pods.
Expand Down
3 changes: 2 additions & 1 deletion scripts/ci/libraries/_kind.sh
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,8 @@ function kind::deploy_airflow_with_helm() {
--set "defaultAirflowTag=${AIRFLOW_PROD_BASE_TAG}-kubernetes" -v 1 \
--set "config.api.auth_backend=airflow.api.auth.backend.default" \
--set "config.api.enable_experimental_api=true" \
--set "config.logging.logging_level=DEBUG"
--set "config.logging.logging_level=DEBUG" \
--set "executor=KubernetesExecutor"
echo
popd > /dev/null 2>&1|| exit 1
}
Expand Down

0 comments on commit c7cd437

Please sign in to comment.