Skip to content

Commit

Permalink
Shorten max pre-commit hook name length (#23677)
Browse files Browse the repository at this point in the history
When names are too long, pre-commit output looks very ugly and takes up 2x lines. Here I reduce max length just a little bit further so that pre-commit output renders properly on a macbook pro 16" with terminal window splitting screen horizontally.
  • Loading branch information
dstandish authored May 12, 2022
1 parent 7277122 commit c74e67a
Show file tree
Hide file tree
Showing 3 changed files with 194 additions and 192 deletions.
6 changes: 3 additions & 3 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@ repos:
pass_filenames: true
- id: check-start-date-not-used-in-defaults
language: pygrep
name: "'start_date' should not be defined in default_args in example_dags"
name: "'start_date' not to be defined in default_args in example_dags"
entry: "default_args\\s*=\\s*{\\s*(\"|')start_date(\"|')|(\"|')start_date(\"|'):"
files: \.*example_dags.*\.py$
exclude: ^airflow/_vendor/
Expand Down Expand Up @@ -603,10 +603,10 @@ repos:
- 'jsonpath-ng==1.5.3'
- 'rich>=12.4.1'
- id: check-pre-commit-information-consistent
name: Update information about pre-commit hooks and verify ids and names
name: Update information re pre-commit hooks and verify ids and names
entry: ./scripts/ci/pre_commit/pre_commit_check_pre_commit_hooks.py
args:
- --max-length=70
- --max-length=64
language: python
files: ^\.pre-commit-config\.yaml$|^scripts/ci/pre_commit/pre_commit_check_pre_commit_hook_names\.py$
additional_dependencies: ['pyyaml', 'jinja2', 'black==22.3.0', 'tabulate', 'rich>=12.4.1']
Expand Down
Loading

0 comments on commit c74e67a

Please sign in to comment.