Use run_id for ti.mark_success_url (#23330)

apache · Apr 28, 2022 · a5f9df5 · a5f9df5
1 parent 67e8bdd
commit a5f9df5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/airflow/models/taskinstance.py b/airflow/models/taskinstance.py
@@ -803,13 +803,12 @@ def log_url(self):
     @property
     def mark_success_url(self):
         """URL to mark TI success"""
-        iso = quote(self.execution_date.isoformat())
         base_url = conf.get('webserver', 'BASE_URL')
         return base_url + (
             "/confirm"
             f"?task_id={self.task_id}"
             f"&dag_id={self.dag_id}"
-            f"&execution_date={iso}"
+            f"&dag_run_id={quote(self.run_id)}"
             "&upstream=false"
             "&downstream=false"
             "&state=success"

diff --git a/tests/models/test_taskinstance.py b/tests/models/test_taskinstance.py
@@ -1312,7 +1312,8 @@ def test_mark_success_url(self, create_task_instance):
         )
         assert query['dag_id'][0] == 'dag'
         assert query['task_id'][0] == 'op'
-        assert pendulum.parse(query['execution_date'][0]) == now
+        assert query['dag_run_id'][0] == 'test'
+        assert ti.execution_date == now
 
     def test_overwrite_params_with_dag_run_conf(self, create_task_instance):
         ti = create_task_instance()