Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Jed Cunningham <[email protected]>
  • Loading branch information
Aakcht and jedcunningham committed Jun 22, 2023
1 parent 09be379 commit 9ebb9e9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 0 additions & 2 deletions chart/templates/_helpers.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -875,8 +875,6 @@ capabilities:

The template can be called like so:
include "externalContainerSecurityContext" .Values.statsd

Where `.` is the global variables scope and `.Values.webserver` the local variables scope for the webserver template.
*/}}
{{- define "externalContainerSecurityContext" -}}
{{- if .securityContexts.container -}}
Expand Down
1 change: 1 addition & 0 deletions tests/charts/security/test_security_context.py
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,7 @@ def test_global_security_context(self):
"spec.template.spec.containers[0].securityContext", docs[index]
)
assert ctx_value_pod == jmespath.search("spec.template.spec.securityContext", docs[index])

# Global security context is not propagated to redis and statsd, so we test default value
default_ctx_value_container = {"allowPrivilegeEscalation": False, "capabilities": {"drop": ["ALL"]}}
default_ctx_value_pod_statsd = {"runAsUser": 65534}
Expand Down

0 comments on commit 9ebb9e9

Please sign in to comment.