Refactor: Simplify dict manipulation in metrics

apache · Aug 9, 2023 · 762a491 · 762a491
1 parent e114312
commit 762a491
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/airflow/metrics/otel_logger.py b/airflow/metrics/otel_logger.py
@@ -309,12 +309,9 @@ def get_counter(self, name: str, attributes: Attributes = None):
         :param attributes:  Counter attributes, used to generate a unique key to store the counter.
         """
         key = _generate_key_name(name, attributes)
-        if key in self.map.keys():
-            return self.map[key]
-        else:
-            new_counter = self._create_counter(name)
-            self.map[key] = new_counter
-            return new_counter
+        if key not in self.map:
+            self.map[key] = self._create_counter(name)
+        return self.map[key]
 
     def del_counter(self, name: str, attributes: Attributes = None) -> None:
         """