Added spinner activity while the logs load (#31165)

* spinner added * fixed static checks * isFetching * isFetching replaced with isLoading
apache · May 10, 2023 · 584a9f5 · 584a9f5
1 parent 420a9b1
commit 584a9f5
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/airflow/www/static/js/api/useTaskLog.ts b/airflow/www/static/js/api/useTaskLog.ts
@@ -74,7 +74,6 @@ const useTaskLog = ({
       });
     },
     {
-      placeholderData: "",
       refetchInterval:
         expectingLogs && isRefreshOn && (autoRefreshInterval || 1) * 1000,
     }

diff --git a/airflow/www/static/js/dag/details/taskInstance/Logs/index.tsx b/airflow/www/static/js/dag/details/taskInstance/Logs/index.tsx
@@ -26,6 +26,7 @@ import {
   Button,
   Checkbox,
   Icon,
+  Spinner,
 } from "@chakra-ui/react";
 import { MdWarning } from "react-icons/md";
 
@@ -119,7 +120,7 @@ const Logs = ({
   const { timezone } = useTimezone();
 
   const taskTryNumber = selectedTryNumber || tryNumber || 1;
-  const { data } = useTaskLog({
+  const { data, isLoading } = useTaskLog({
     dagId,
     dagRunId,
     taskId,
@@ -266,12 +267,16 @@ const Logs = ({
               <Text fontSize="sm">{warning}</Text>
             </Flex>
           )}
-          {!!parsedLogs && (
-            <LogBlock
-              parsedLogs={parsedLogs}
-              wrap={wrap}
-              tryNumber={taskTryNumber}
-            />
+          {isLoading ? (
+            <Spinner />
+          ) : (
+            !!parsedLogs && (
+              <LogBlock
+                parsedLogs={parsedLogs}
+                wrap={wrap}
+                tryNumber={taskTryNumber}
+              />
+            )
           )}
         </>
       )}
-Original file line number
+Diff line change
@@ Expand Up / @@ -74,7 +74,6 @@ const useTaskLog = ({ @@
           });
         },
         {
-          placeholderData: "",
           refetchInterval:
             expectingLogs && isRefreshOn && (autoRefreshInterval || 1) * 1000,
         }
@@ Expand Down @@