Use if block for better readability

apache · Aug 1, 2024 · 50c7415 · 50c7415
1 parent 10ee46d
commit 50c7415
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/airflow/decorators/base.py b/airflow/decorators/base.py
@@ -458,12 +458,9 @@ def _expand(self, expand_input: ExpandInput, *, strict: bool) -> XComArg:
         if partial_kwargs.get("pool") is None:
             partial_kwargs["pool"] = Pool.DEFAULT_POOL_NAME
         if partial_kwargs.get("pool_slots") and partial_kwargs["pool_slots"] < 1:
-            dag_str = (
-                f""" in dag {partial_kwargs['dag'].dag_id
-                                   }"""
-                if partial_kwargs.get("dag")
-                else ""
-            )
+            dag_str = ""
+            if partial_kwargs.get("dag"):
+                dag_str = f" in dag {partial_kwargs['dag'].dag_id}"
             raise ValueError(f"pool slots for {task_id}{dag_str} cannot be less than 1")
         partial_kwargs["retries"] = parse_retries(partial_kwargs.get("retries", DEFAULT_RETRIES))
         partial_kwargs["retry_delay"] = coerce_timedelta(

diff --git a/airflow/models/baseoperator.py b/airflow/models/baseoperator.py
@@ -363,12 +363,9 @@ def partial(
     if partial_kwargs["pool"] is None:
         partial_kwargs["pool"] = Pool.DEFAULT_POOL_NAME
     if partial_kwargs["pool_slots"] < 1:
-        dag_str = (
-            f""" in dag {partial_kwargs['dag'].dag_id
-                               }"""
-            if partial_kwargs["dag"]
-            else ""
-        )
+        dag_str = ""
+        if partial_kwargs["dag"]:
+            dag_str = f" in dag {partial_kwargs['dag'].dag_id}"
         raise ValueError(f"pool slots for {partial_kwargs['task_id']}{dag_str} cannot be less than 1")
     partial_kwargs["retries"] = parse_retries(partial_kwargs["retries"])
     partial_kwargs["retry_delay"] = coerce_timedelta(partial_kwargs["retry_delay"], key="retry_delay")