Skip to content

Commit

Permalink
Update version of Google ADS
Browse files Browse the repository at this point in the history
  • Loading branch information
Ulada Zakharava committed Oct 29, 2024
1 parent 19ddb02 commit 2e9d077
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
2 changes: 1 addition & 1 deletion generated/provider_dependencies.json
Original file line number Diff line number Diff line change
Expand Up @@ -634,7 +634,7 @@
"gcloud-aio-bigquery>=6.1.2",
"gcloud-aio-storage>=9.0.0",
"gcsfs>=2023.10.0",
"google-ads>=25.0.0",
"google-ads>=25.1.0",
"google-analytics-admin>=0.9.0",
"google-api-core>=2.11.0,!=2.16.0,!=2.18.0",
"google-api-python-client>=2.0.2",
Expand Down
12 changes: 5 additions & 7 deletions providers/src/airflow/providers/google/ads/hooks/ads.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@
from airflow.providers.google.common.hooks.base_google import get_field

if TYPE_CHECKING:
from google.ads.googleads.v17.services.services.customer_service import CustomerServiceClient
from google.ads.googleads.v17.services.services.google_ads_service import GoogleAdsServiceClient
from google.ads.googleads.v17.services.types.google_ads_service import GoogleAdsRow
from google.ads.googleads.v18.services.services.customer_service import CustomerServiceClient
from google.ads.googleads.v18.services.services.google_ads_service import GoogleAdsServiceClient
from google.ads.googleads.v18.services.types.google_ads_service import GoogleAdsRow
from google.api_core.page_iterator import GRPCIterator


Expand Down Expand Up @@ -101,16 +101,14 @@ class GoogleAdsHook(BaseHook):
:param api_version: The Google Ads API version to use.
"""

default_api_version = "v17"

def __init__(
self,
api_version: str | None,
api_version: str | None = None,
gcp_conn_id: str = "google_cloud_default",
google_ads_conn_id: str = "google_ads_default",
) -> None:
super().__init__()
self.api_version = api_version or self.default_api_version
self.api_version = api_version
self.gcp_conn_id = gcp_conn_id
self.google_ads_conn_id = google_ads_conn_id
self.google_ads_config: dict[str, Any] = {}
Expand Down
2 changes: 1 addition & 1 deletion providers/src/airflow/providers/google/provider.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ dependencies:
- gcloud-aio-bigquery>=6.1.2
- gcloud-aio-storage>=9.0.0
- gcsfs>=2023.10.0
- google-ads>=25.0.0
- google-ads>=25.1.0
- google-analytics-admin>=0.9.0
# Google-api-core 2.16.0 back-compat issue:
# - https://github.com/googleapis/python-api-core/issues/576
Expand Down

0 comments on commit 2e9d077

Please sign in to comment.