-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix daskexecutor provider docs #907
Conversation
Well. We SHOULD release daskexecutor 1.1.1 as part of this wave. That's the whole point of having the last release which will have "removed" notice in the This is defined as part of the removal process. |
So both - releasing 1.1.1 package and documentation for it are absolutely intended and needed. |
No... |
Ah then 1.2.0 is wrong. We should not bump Airflow min version for daskexecutor. The "upgrade min airflow" release command will sklp bumping it at least (deliberately) We should not bump min-airflow version for this package - it should be identical as the last released version with the only difference being the description in |
That means modifying pre-commit and enabling 2.5.0 back
Why do you feel strongly about it? what is the down side? |
Does it? I think we do not do any pre-commit that would prevent dask executor to keep 2.5.0 (but maybe I am wrong and we need to FIX a pre-commit in question to allow it for removed providers).
Because the only reason for releasing the package is that we want the Bumping min-version only makes sense when we want to have some future changes there to make people "want" to upgrade to newer version of Airflow. In case of removed provider - this motivation for bumping min-airflow version is gone (because there are no new features, and will not be new features any more) so bumping min-airflow version in this case is nothing else than "cargo cult" - we will do it because we generally do it for other packages, without actual reason for doing it. I cannot think of particular scenario where it would be problematic, but I think there is simply absolutely no reason do it. And I very much don't like we do anything unless we have a good reason for it. |
Following our discussion closed due to apache/airflow#36191 |
There is no daskexecutor 1.1.1
It seems that doc build created this package though it wasn't part of the release wave - I will investigate and fix the problem with the doc build