Implement list comprehension #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add initial code for list comprehension
- Additionally, fixed a bug in nested queries.
* Resolve variable scope and ambigous variable issue
- For scoping the variable, remove the pnsi from namespace list after
being used by the list comprehension.
- To resolve the ambigous variable issue, only scan the pnsi of
list_comp subquery.
* Fix non agg plan node issue in list comprehension
- Resolved the issue 'aggref found in non-agg plan node'
when the list comprehension is used as a property constraint in
MATCH and other clauses or when used in WHERE clause. Intead of adding
qual in the jointree, we are now adding the qual in having node of
query.
e.g.
MATCH (n {list: [for i in [1,2,3]]})
MATCH (n) WHERE n.list=[for i in [1,2,3]]
WITH n WHERE n.list=[for i in [1,2,3]]
- Removed redundant call to function tranform_cypher_clause_with_where
by tranform_match_clause.
* Resolve variable reuse issue in list comprehension
- Also, for scoping list comprehension variable, instead of removing
the pnsi of list comp from namespace, now we just mark the cols of
pnsi as not visible.
* Modify grammer to match opencypher list comprehension grammer
- Also added initial regression tests for list comprehension
* Add regression tests for bugs resolved
- Includes tests for nested cases, ambigous variable issue, list
comprehension variable scoping and planner node aggref issue.
- Should be added more.
* Resolve invalid output on multiple list comprehensions
- Fix the output of multiple list comprehensions in the RETURN clause
and the WHERE clause.
- Added regression tests for the above and some for the previous bugs
resolved.
* Fix aggref found where not expected issue (#189)
- Resolved the 'aggref found where not expected' error thrown when
using list comprehensions in UNWIND, or as a property update
expression in SET or in the comparison expressions, typecasts or
string matching in WITH - WHERE clause
- Added an error to be thrown when using aggregation functions in UNWIND
and property update expr in SET clause
- Added regression tests
* cleanup: Remove dead code and formatting changes
---------
Co-authored-by: John Gemignani <[email protected]>
Co-authored-by: Zainab Saad <[email protected]>
- The grammar had a shift/reduce conflict due to the ambiguity of the `IN` keyword. This is resolved by adding generic rule and manually resolving to the correct specific rule. - Added additional test cases.
jrgemignani
approved these changes
Apr 8, 2024
|
Looks good to me~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the OpenCypher spec for List Comprehension to AGE. Also added a commit to remove shift/reduce conflict in grammar.
Syntax
Example
Known Issue
List comprehension as property constraint of MERGE clause errors out. Created issue #1611 for that.
Co-authored-by:
John Jemignani
Zainab Saad
Muhammad Taha Naveed